Merge lp://qastaging/~danilo/charms/trusty/glance-simplestreams-sync/invert-failure-mode into lp://qastaging/~landscape/charms/trusty/glance-simplestreams-sync/landscape
Proposed by
Данило Шеган
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 66 | ||||
| Proposed branch: | lp://qastaging/~danilo/charms/trusty/glance-simplestreams-sync/invert-failure-mode | ||||
| Merge into: | lp://qastaging/~landscape/charms/trusty/glance-simplestreams-sync/landscape | ||||
| Diff against target: |
96 lines (+27/-46) 1 file modified
scripts/glance-simplestreams-sync.py (+27/-46) |
||||
| To merge this branch: | bzr merge lp://qastaging/~danilo/charms/trusty/glance-simplestreams-sync/invert-failure-mode | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Geoff Teale (community) | Approve | ||
| Bogdana Vereha (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
We've hit a number of cases where glance-
That has long pointed as at the fact that it'd be better to invert the logic there: only drop the per-minute cronjob on actual success.
This will mean that it will indefinitely retry even with fatal failures, but that's not a big deal for us, since our installation can take forever as well.
I'll do another test run before merging this in and after addressing all the review comments, fwiw.
To post a comment you must log in.
Revision history for this message
| Данило Шеган (danilo) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good (considering the circumstances) :)