Merge lp://qastaging/~danilo/charms/trusty/glance-simplestreams-sync/next-lock-fix into lp://qastaging/charms/trusty/glance-simplestreams-sync
Proposed by
Данило Шеган
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://qastaging/~danilo/charms/trusty/glance-simplestreams-sync/next-lock-fix |
| Merge into: | lp://qastaging/charms/trusty/glance-simplestreams-sync |
| Diff against target: |
12 lines (+1/-0) 1 file modified
scripts/glance-simplestreams-sync.py (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~danilo/charms/trusty/glance-simplestreams-sync/next-lock-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| charmers | Pending | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2016-04-12.
Description of the change
Only remove the lock file on exit if it was acquired in the first place. Stop it from hitting races and downloading same images multiple times.
See bug for details. Without this fix, the log had things like:
http://
which resulted in 2 xenial images and 1 trusty image.
With the fix, the result is a more reasonable
To post a comment you must log in.
Revision history for this message
| Данило Шеган (danilo) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
We've started off with next charm, and this issue does not seem to affect trunk :/
What's the current situation with this charm? What is the latest and greatest to use? Landscape Autopilot is using it, and we do need some changes on top of it for now.