Merge lp://qastaging/~danilo/landscape-client/bpickle-no-3 into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: 962
Merged at revision: 961
Proposed branch: lp://qastaging/~danilo/landscape-client/bpickle-no-3
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 169 lines (+14/-13)
12 files modified
landscape/broker/ping.py (+1/-1)
landscape/broker/store.py (+1/-1)
landscape/broker/tests/test_ping.py (+1/-1)
landscape/broker/tests/test_transport.py (+1/-1)
landscape/broker/transport.py (+1/-1)
landscape/compat.py (+0/-2)
landscape/lib/amp.py (+1/-1)
landscape/lib/persist.py (+1/-1)
landscape/lib/tests/test_bpickle.py (+1/-1)
landscape/package/reporter.py (+2/-1)
landscape/package/store.py (+2/-1)
landscape/package/tests/test_reporter.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~danilo/landscape-client/bpickle-no-3
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
🤖 Landscape Builder test results Approve
Alberto Donato (community) Approve
Review via email: mp+320157@code.qastaging.launchpad.net

Commit message

Rename bpickle3 back to bpickle and drop indirect imports through landscape.compat.

Description of the change

Rename bpickle3 back to bpickle and drop indirect imports through landscape.compat.

Testing instructions:

make check, ensure https://ci.lscape.net/job/landscape-package/ builds successfully.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 961
Branch: lp:~danilo/landscape-client/bpickle-no-3
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3634/

review: Approve (test results)
Revision history for this message
Alberto Donato (ack) wrote :

LGTM, +1

review: Approve
962. By Данило Шеган

Revert Makefile change.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 962
Branch: lp:~danilo/landscape-client/bpickle-no-3
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3635/

review: Approve (test results)
Revision history for this message
Adam Collard (adam-collard) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: