Merge lp://qastaging/~danilo/landscape-client/mock-tests-broker-exchange into lp://qastaging/~landscape/landscape-client/trunk
Proposed by
Данило Шеган
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Данило Шеган | ||||
| Approved revision: | 844 | ||||
| Merged at revision: | 865 | ||||
| Proposed branch: | lp://qastaging/~danilo/landscape-client/mock-tests-broker-exchange | ||||
| Merge into: | lp://qastaging/~landscape/landscape-client/trunk | ||||
| Diff against target: |
55 lines (+12/-9) 1 file modified
landscape/broker/tests/test_exchange.py (+12/-9) |
||||
| To merge this branch: | bzr merge lp://qastaging/~danilo/landscape-client/mock-tests-broker-exchange | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| 🤖 Landscape Builder | test results | Approve | |
| Free Ekanayaka (community) | Approve | ||
| Chris Glass (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Kill mocker use in landscape/
I am not too happy about mocking the private exchange._reactor in the second test: since it's set-up in setUp, the only alternative I see is to re-create it like the first test does.
Description of the change
Kill mocker use in landscape/
I am not too happy about mocking the private exchange._reactor in the second test: since it's set-up in setUp, the only alternative I see is to re-create it like the first test does.
To post a comment you must log in.
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) | # |
review:
Abstain
(executing tests)
Revision history for this message
| 🤖 Landscape Builder (landscape-builder) wrote | # |
review:
Approve
(test results)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1