Landscape Client

Merge lp://qastaging/~danilo/landscape-client/mock-tests-sysinfo-deployment into lp://qastaging/~landscape/landscape-client/trunk

  1. mock-tests-sysinfo-deployment
  2. Merge into trunk
Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: 849
Merged at revision: 891
Proposed branch: lp://qastaging/~danilo/landscape-client/mock-tests-sysinfo-deployment
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 180 lines (+64/-68)
1 file modified
landscape/sysinfo/tests/test_deployment.py (+64/-68)
To merge this branch: bzr merge lp://qastaging/~danilo/landscape-client/mock-tests-sysinfo-deployment
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Benji York (community) Approve
Adam Collard (community) Approve
Review via email: mp+297579@code.qastaging.launchpad.net

Commit message

Migrate landscape/sysinfo/tests/test_deployment.py from mocker to mock.

Description of the change

Migrate landscape/sysinfo/tests/test_deployment.py from mocker to mock.

The trickier one was test_output_is_only_displayed_once_deferred_fires.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Fail
Revno: 848
Branch: lp:~danilo/landscape-client/mock-tests-sysinfo-deployment
Jenkins: https://ci.lscape.net/job/latch-test/5081/

review: Needs Fixing (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 848
Branch: lp:~danilo/landscape-client/mock-tests-sysinfo-deployment
Jenkins: https://ci.lscape.net/job/latch-test/5088/

review: Approve (test results)
Revision history for this message
Adam Collard (adam-collard) wrote :

Small nit inline

review: Approve
Revision history for this message
Benji York (benji) wrote :

This looks good.

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
Download full text (187.0 KiB)

The attempt to merge lp:~danilo/landscape-client/mock-tests-sysinfo-deployment into lp:landscape-client failed. Below is the output from the failed tests.

python setup.py build_ext -i
running build_ext
Running 2170 tests.
landscape.broker.tests.test_amp
  RemoteBrokerTest
    test_call_if_accepted ... [OK]
    test_fire_event ... [OK]
    test_get_accepted_message_types ... [OK]
    test_call_if_accepted_with_not_accepted ... [OK]
    test_is_message_pending ... [OK]
    test_listen_events ... [OK]
    test_get_server_uuid ... [OK]
    test_ping ... [OK]
    test_method_call_error ... [OK]
    test_register_client ... [OK]
    test_register ... [OK]
    test_register_client_accepted_message_type ... [OK]
    test_reload_configuration ... [OK]
    test_send_message ... [OK]
    test_send_message_with_urgent ... [OK]
    test_stop_clients ... [OK]
  RemoteClientTest
    test_exit ... [OK]
    test_fire_event ... [OK]
    test_message ... [OK]
    test_method_call_error ... [OK]
    test_ping ... [OK]
landscape.broker.tests.test_client
  BrokerClientTest
    test_add ... [OK]
    test_dispatch_message ... [OK]
    test_dispatch_message_with_exception ... [OK]
    test_dispatch_message_with_no_handler ... [OK]
    test_exchange ... [OK]
    test_exchange_logs_errors_and_continues ... [OK]
    test_exchange_on_plugin_without_exchange_method ... [OK]
    test_exit ... [OK]
    test_fire_event ... [OK]
    test_fire_event_with_acceptance_changed ... [OK]
    test_fire_event_with_arguments ... [OK]
    test_fire_event_with_mixed_results ... [OK]
    test_get_named_plugin ... [OK]
    test_get_plugins_returns_a_copy ... [OK]
    test_get_plugins ... ...

Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

No approved revision specified.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 849
Branch: lp:~danilo/landscape-client/mock-tests-sysinfo-deployment
Jenkins: https://ci.lscape.net/job/latch-test/5093/

review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: