Merge lp://qastaging/~danilo/linaro-android-frontend/bug-942671 into lp://qastaging/linaro-android-frontend

Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: 251
Merged at revision: 251
Proposed branch: lp://qastaging/~danilo/linaro-android-frontend/bug-942671
Merge into: lp://qastaging/linaro-android-frontend
Diff against target: 134 lines (+112/-0)
2 files modified
android_build/templates/base.html (+1/-0)
android_build/templates/index.html (+111/-0)
To merge this branch: bzr merge lp://qastaging/~danilo/linaro-android-frontend/bug-942671
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+98631@code.qastaging.launchpad.net

Description of the change

Introduce the (static) introductory text for android-build, as requested by Zach.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

My only concern is that this text appears a bit misplaced - android-build.linaro.org is (to the best of my knowledge) is internal engineering system, to which we just provide open access, but not exactly a frontend into Linaro public resources. IMHO, such text would look better somewhere on releases.linaro.org or snapshots.linaro.org.

Another issue is that the text is long. Nobody else but our engineers would suffer thru constant scrolling to get to real build results.

Well, I assume that these organizational issues were considered already. Implementation-wise, looks good.

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

Thanks for the comment and review: while it is a service oriented to engineers, those are exactly who we want to cater to with the introductory text. And in case they ended up here by mistake, show them the way.

Zach has a big desire to make this the central point for Android. I, otoh, have a big desire to make it a central point for all of CI in Linaro. But until I am ready to make the call for the latter, I don't mind it serving his purpose better.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches