Linaro Image Tools

Merge lp://qastaging/~danilo/linaro-image-tools/more-pep8-fixes into lp://qastaging/linaro-image-tools/11.11

  1. more-pep8-fixes
  2. Merge into trunk
Proposed by Данило Шеган
Status: Merged
Approved by: Milo Casagrande
Approved revision: 536
Merged at revision: 527
Proposed branch: lp://qastaging/~danilo/linaro-image-tools/more-pep8-fixes
Merge into: lp://qastaging/linaro-image-tools/11.11
Diff against target: 1834 lines (+431/-357)
32 files modified
linaro_image_tools/cmd_runner.py (+1/-1)
linaro_image_tools/hwpack/__init__.py (+2/-2)
linaro_image_tools/hwpack/better_tarfile.py (+2/-2)
linaro_image_tools/hwpack/builder.py (+4/-3)
linaro_image_tools/hwpack/config.py (+12/-11)
linaro_image_tools/hwpack/hardwarepack.py (+47/-41)
linaro_image_tools/hwpack/hardwarepack_format.py (+2/-2)
linaro_image_tools/hwpack/packages.py (+2/-2)
linaro_image_tools/hwpack/tarfile_matchers.py (+2/-2)
linaro_image_tools/hwpack/testing.py (+4/-3)
linaro_image_tools/hwpack/tests/__init__.py (+2/-2)
linaro_image_tools/hwpack/tests/test_better_tarfile.py (+2/-2)
linaro_image_tools/hwpack/tests/test_builder.py (+14/-13)
linaro_image_tools/hwpack/tests/test_config.py (+158/-138)
linaro_image_tools/hwpack/tests/test_hardwarepack.py (+12/-6)
linaro_image_tools/hwpack/tests/test_packages.py (+4/-3)
linaro_image_tools/hwpack/tests/test_script.py (+2/-2)
linaro_image_tools/hwpack/tests/test_tarfile_matchers.py (+2/-2)
linaro_image_tools/hwpack/tests/test_testing.py (+2/-2)
linaro_image_tools/media_create/__init__.py (+5/-3)
linaro_image_tools/media_create/android_boards.py (+18/-9)
linaro_image_tools/media_create/boards.py (+64/-50)
linaro_image_tools/media_create/check_device.py (+1/-1)
linaro_image_tools/media_create/chroot_utils.py (+5/-3)
linaro_image_tools/media_create/rootfs.py (+5/-3)
linaro_image_tools/media_create/tests/test_media_create.py (+42/-33)
linaro_image_tools/media_create/unpack_binary_tarball.py (+1/-1)
linaro_image_tools/testing.py (+2/-2)
linaro_image_tools/tests/fixtures.py (+2/-1)
linaro_image_tools/tests/test_pep8.py (+6/-9)
linaro_image_tools/tests/test_utils.py (+2/-1)
linaro_image_tools/utils.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~danilo/linaro-image-tools/more-pep8-fixes
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Loïc Minier (community) Approve
Review via email: mp+110100@code.qastaging.launchpad.net

Description of the change

Fix the remaining PEP-8 problems and remove ignored problems that we can.

To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

LGTM; albeit note that this will make it harder to blame these lines for relatively little win -- but no objection to cleaning it up once

Revision history for this message
Loïc Minier (lool) :
review: Approve
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Had a quick read and seems fine to me, but I think a merge of this size should have another pair of eyes on it as well since I am sure I drifted off in the middle :-) Thankfully Milo is down to do the review!

Revision history for this message
Milo Casagrande (milo) wrote :

Hello there!

Have gone through the big-diff (and my eyes are still sane), and looks good to me!
Thanks Danilo for fixing all these things!

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

@Loic, it indeed would, but at this time, there's probably little value in finding out that most of the lines were actually done by people who are not in Linaro anymore (JamesW, Salgado, Mattias :).

Everyone, thanks for your reviews!

Revision history for this message
Loïc Minier (lool) wrote :

blame >> I meant to find out which commit (with commit message) introduced this or that construct; anyway, it's all good :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches