Merge lp://qastaging/~danilo/linaro-license-protection/staging-publish into lp://qastaging/~linaro-automation/linaro-license-protection/trunk

Proposed by Данило Шеган
Status: Merged
Approved by: Stevan Radaković
Approved revision: 114
Merged at revision: 110
Proposed branch: lp://qastaging/~danilo/linaro-license-protection/staging-publish
Merge into: lp://qastaging/~linaro-automation/linaro-license-protection/trunk
Diff against target: 392 lines (+228/-61)
2 files modified
scripts/publish_to_snapshots.py (+90/-27)
tests/test_publish_to_snapshots.py (+138/-34)
To merge this branch: bzr merge lp://qastaging/~danilo/linaro-license-protection/staging-publish
Reviewer Review Type Date Requested Status
Stevan Radaković code Approve
Review via email: mp+120861@code.qastaging.launchpad.net

Description of the change

This adds an option to do publishing to staging as well, which includes
a trivial sanitization: the file is truncated and the base of the filename
is written as the contents instead.

Some side-refactoring, and mostly all things are tested.

To post a comment you must log in.
115. By Данило Шеган

Lint fixes.

Revision history for this message
Stevan Radaković (stevanr) wrote :

Looks good.
As I've mentioned, we should probably increase the list of accepted files but we can do it 'nother time.
Approve +1.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches