Merge lp://qastaging/~danilo/lp2kanban/charm-urls into lp://qastaging/lp2kanban
Proposed by
Данило Шеган
| Status: | Merged |
|---|---|
| Merged at revision: | 134 |
| Proposed branch: | lp://qastaging/~danilo/lp2kanban/charm-urls |
| Merge into: | lp://qastaging/lp2kanban |
| Diff against target: |
98 lines (+61/-2) 2 files modified
src/lp2kanban/kanban.py (+2/-2) src/lp2kanban/tests/test_bugs2cards.py (+59/-0) |
| To merge this branch: | bzr merge lp://qastaging/~danilo/lp2kanban/charm-urls |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Collard (community) | Approve | ||
| Free Ekanayaka (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Support charm URLs in card external links.
They are basically of the form
lp:~USER.NAME/charms/SERIES/CHARM.NAME/BRANCH
Done a few test runs with kanban-sync job, eg.
https:/
(look for "won't sync" messages), and compare to earlier run
https:/
(check out "won't sync" and "Invalid branch url" messages).
Sneaked in a fix for branch names with periods (look for Chad's one in the broken output).
To post a comment you must log in.
Revision history for this message
| Adam Collard (adam-collard) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me, +1