Merge lp://qastaging/~danilo/lp2kanban/skip-over-wip-errors into lp://qastaging/lp2kanban
| Status: | Merged |
|---|---|
| Merged at revision: | 132 |
| Proposed branch: | lp://qastaging/~danilo/lp2kanban/skip-over-wip-errors |
| Merge into: | lp://qastaging/lp2kanban |
| Diff against target: |
88 lines (+35/-5) 4 files modified
src/lp2kanban/bugs2cards.py (+11/-4) src/lp2kanban/kanban.py (+7/-1) src/lp2kanban/tests/common.py (+1/-0) src/lp2kanban/tests/test_bugs2cards.py (+16/-0) |
| To merge this branch: | bzr merge lp://qastaging/~danilo/lp2kanban/skip-over-wip-errors |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chad Smith | Approve | ||
| Alberto Donato (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Ignore card save errors and continue processing other cards
We've started hitting WIP limits when attempting to create cards (WIP limits are used on the bug squad's Next lane).
This causes lp2kanban to stop processing any other cards, so we decided to ignore errors on such cards as a quick work-around.
This is not the perfect approach, and a similar change might be required in the _moveCard around the post(). Note that post() throws IOError, so we catch that, even though we could pass in handle_errors=False and handle each individual error separately, but that would be a bit more work than just this.
There are no tests for this code, so I am not starting them here either.
Sample test run with this branch:
https:/
Run before that that failed
| Chad Smith (chad.smith) wrote | # |
| Chad Smith (chad.smith) | # |
LGTM, +1