pygettextpo

Merge lp://qastaging/~danilo/pygettextpo/msgctxt-support into lp://qastaging/pygettextpo

  1. msgctxt-support
  2. Merge into trunk
Proposed by Данило Шеган
Status: Needs review
Proposed branch: lp://qastaging/~danilo/pygettextpo/msgctxt-support
Merge into: lp://qastaging/pygettextpo
Prerequisite: lp://qastaging/~danilo/pygettextpo/simplify
Diff against target: 303 lines (+96/-93)
2 files modified
gettextpo.c (+82/-92)
test_gettextpo.py (+14/-1)
To merge this branch: bzr merge lp://qastaging/~danilo/pygettextpo/msgctxt-support
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+92726@code.qastaging.launchpad.net

Description of the change

Provide support for msgctxt field in GNU gettext PO files.

This depends on the 'simplify' branch which simplifies the C code to reduce repeating of the same pattern. A new test is added to ensure this works like the other fields.

http://www.gnu.org/software/gettext/manual/gettext.html#PO-Files

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Looks good.

review: Approve (code)
Reply
Revision history for this message
Colin Watson (cjwatson) wrote :

I've converted pygettextpo to git and merged this branch (though I can't mark this MP as Merged):

  https://git.launchpad.net/pygettextpo/commit/?id=771d6e7853f6149cec3cf93aa0ab58a397ff11c5

Reply

Unmerged revisions

29. By Данило Шеган

Re-merge simplify branch.

28. By Данило Шеган

Merge 'simplify' branch, make use of the refactoring for set_msgctxt.

27. By Данило Шеган

Merge pep8-fixes branch.

26. By Данило Шеган

Make msgctxt support conditional.

25. By Данило Шеган

Add msgctxt support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches