Laika

Merge lp://qastaging/~dannf/laika/support-multiple-date-types into lp://qastaging/laika

  1. support-multiple-date-types
  2. Merge into master
Proposed by dann frazier
Status: Merged
Merged at revision: 20
Proposed branch: lp://qastaging/~dannf/laika/support-multiple-date-types
Merge into: lp://qastaging/laika
Diff against target: 27 lines (+12/-5)
1 file modified
laika (+12/-5)
To merge this branch: bzr merge lp://qastaging/~dannf/laika/support-multiple-date-types
Reviewer Review Type Date Requested Status
Alex Chiang Approve
Review via email: mp+100469@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Peter Petrakis (peter-petrakis) wrote :

Why not just cast lpdate to str and take split from there? The lang is
duck typing after all and there isn't any other actions taken here. Now
you've got two code paths that do the same thing when:

dt = datetime.datetime.strptime(str(lpdate).split('.')[0], '%Y-%m-%dT%H:%M:%S')

will do.

Revision history for this message
Alex Chiang (achiang) wrote :

Thanks dannf.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches