Midori Web Browser

Merge lp://qastaging/~dannote/midori/luaplugin into lp://qastaging/midori

  1. luaplugin
  2. Merge into trunk
Proposed by Danila Poyarkov
Status: Needs review
Proposed branch: lp://qastaging/~dannote/midori/luaplugin
Merge into: lp://qastaging/midori
Diff against target: 261 lines (+64/-49)
7 files modified
CMakeLists.txt (+9/-0)
cmake/GIR.cmake (+10/-4)
extensions/CMakeLists.txt (+6/-0)
midori/midori-browser.c (+0/-5)
midori/midori-privatedata.c (+2/-0)
midori/midori-view.c (+0/-3)
midori/midori-websettings.c (+37/-37)
To merge this branch: bzr merge lp://qastaging/~dannote/midori/luaplugin
Reviewer Review Type Date Requested Status
Cris Dywan Needs Fixing
Review via email: mp+260016@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Danila Poyarkov (dannote) wrote :

Lua plugin is stub but if there is any interest in such thing, I can continue the development. I can also rearrange this branch in two separate commits.

Reply
lp://qastaging/~dannote/midori/luaplugin updated
6959. By Danila Poyarkov <email address hidden>

Uncommented IE user-agent

Revision history for this message
Cris Dywan (kalikiana) wrote :

I think it'd be best to have the build fixes only in this first iteration.

The enum changes won't do as-is because they're used by katze_property_proxy and you'll notice how the preferences dialog and statusbar features look a bit odd.
Maybe it just makes sense to start replacing that code right now, by building the combo boxes by hand - we can look into a new dedicated API to register preferences in a separate branch.

I notice there's gtk2/3 changes in GI. If this will break without having gtk3 installed I'm afraid it needs to become conditional.

review: Needs Fixing
Reply
lp://qastaging/~dannote/midori/luaplugin updated
6960. By Danila Poyarkov <email address hidden>

Stripped off "hide titlebar when maximized"

Revision history for this message
Cris Dywan (kalikiana) wrote :

Whilst I'm trying to get WebKit2 extension API into trunk, on a spontaneous thought of making ibpeas a requirement for that to save the cost of porting existing code, somebody pointed out that there's lua support as of recently. So it's probably better to take advantage of that rather than our own ad-hoc solution.

https://git.gnome.org/browse/libpeas/commit/?id=84a159374c7032f0bc536321df66d4ffac97d9fe

Reply
Revision history for this message
Danila Poyarkov (dannote) wrote :

> If this will break without having gtk3 installed I'm afraid it needs to become conditional.
Yes, it will as it would be impossible to run a mixed GTK2/3 environment.

> https://git.gnome.org/browse/libpeas/commit/?id=84a159374c7032f0bc536321df66d4ffac97d9fe
Looks great, I'll check it out soon.

Reply

Unmerged revisions

6960. By Danila Poyarkov <email address hidden>

Stripped off "hide titlebar when maximized"

6959. By Danila Poyarkov <email address hidden>

Uncommented IE user-agent

6958. By Danila Poyarkov <email address hidden>

Fixed GObject-introspection and created new plugin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: