Merge lp://qastaging/~darkxst/ubuntu-release-upgrader/gnome-session-inhibit into lp://qastaging/ubuntu-release-upgrader

The release upgrade process downloads a tarball of the release-upgrader from the archive for the target release e.g. http://archive.ubuntu.com/ubuntu/dists/xenial/main/dist-upgrader-all/current/xeinal.tar.gz then extracts it to a directory in /tmp/ and then runs xenial in that temporary directory. You could test it by either starting an upgrade, choosing to quit, and then make changes in /tmp/$tmpdir/DistUpgradeQuirks.py or build the package and manually extract dist-upgrader_$vernum.tar.gz.

ok, managed to test it.

It didnt work though since the quirks are run under sudo, there is no access to the user dbus session.

This is fixed now, it kind of feels like jumping through hoops, but I am not sure there is a better way. This is not possible with logind inhibitors and we need the gnome-session-inhibit binary launched with the users (not root) environment and uid.

Since Brian uploaded a change with a sleep inhibitor using logind, I'm thinking this might be better handled by inhibiting "idle" as well in logind? This would fix the screensaver coming on for Kubuntu as well as the gnome-session-based flavors.

That was my patch and I would have included an inhibitor on idle if it worked like that.

Atleast on GNOME (although its likely the same on KDE), the logind "idle" inhibitors do not inhibit the idle monitors within the compositor. logind only deals with system level events/actions like shutdown/sleep, power buttons and lid switch, it has no concept of what his happening within the users session. Its the compositor that is monitoring user input (keyboard/mouse etc) and deciding when to activate the screensaver and screenblanking.

So we still need to install an "idle" inhibitor into the users session.

I'm testing this a bit and will upload / merge it today.