Merge lp://qastaging/~daschuer/mixxx/features_banshee into lp://qastaging/~mixxxdevelopers/mixxx/trunk

Proposed by Daniel Schürmann
Status: Needs review
Proposed branch: lp://qastaging/~daschuer/mixxx/features_banshee
Merge into: lp://qastaging/~mixxxdevelopers/mixxx/trunk
Diff against target: 1547 lines (+1433/-0)
11 files modified
mixxx/build/depends.py (+5/-0)
mixxx/res/mixxx.qrc (+1/-0)
mixxx/src/dlgprefplaylist.cpp (+4/-0)
mixxx/src/dlgprefplaylistdlg.ui (+20/-0)
mixxx/src/library/banshee/bansheedbconnection.cpp (+236/-0)
mixxx/src/library/banshee/bansheedbconnection.h (+115/-0)
mixxx/src/library/banshee/bansheefeature.cpp (+292/-0)
mixxx/src/library/banshee/bansheefeature.h (+83/-0)
mixxx/src/library/banshee/bansheeplaylistmodel.cpp (+520/-0)
mixxx/src/library/banshee/bansheeplaylistmodel.h (+149/-0)
mixxx/src/library/library.cpp (+8/-0)
To merge this branch: bzr merge lp://qastaging/~daschuer/mixxx/features_banshee
Reviewer Review Type Date Requested Status
Mixxx Development Team Pending
Review via email: mp+90381@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
n3rd (n3rd) wrote :

Hi,

I have installed the Beta 11 and must say I am really excited to see Banshee being integrated as it improves the workflow a lot! I do not have much time to test it intensively atm, but on a first glance I can access my playlists and load tracks from them.

I noticed a few things though:

- there are a bunch of "playlists" enlisted in Mixxx that aren't actually existing in Banshee or might wanna be hidden such as "queue" and "play list generator"
- the "queue" playlist shows up several times
- there are tracks enlisted in the banshee drop down menu mixed up with the enlisted playlists; the tracks should not be there (Banshee does not even allow tracks in the playlist menu)
- the order of playlists is different to the one in Banshee
- I do not see any of the rating of the tracks, which would be more than nice to have

Thx for the work,

I am happy to keep testing

Any idea if and when it will be integrated into a new release?

Revision history for this message
bubbasan (stuff-whatafool) wrote :

Cannot install on Ubuntu 12.04 due to libprotobuf5 dependency not being met.

2988. By Daniel Schürmann

merged with lp:mixxx

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Just merged with current trunk. It compiles fine on my Ubuntu 12.4 now.

2989. By Daniel Schürmann

merged from lp:mixxx

2990. By Daniel Schürmann

merged from lp:mixxx

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Shall we target this for 1.12.0?

My overall comment is that this is an in-memory copy of the Banshee DB. Could this cause problems for those with large databases?

There is code duplication with the BaseExternal* code that runs Traktor/iTunes/RB. I would prefer that at the beginning you either create a temporary table that matches their expectations of what the table should look like or select the data and insert it into a Mixxx DB temporary table like Traktor/iTunes/RB. That way we can add whole features at once for all of IT/RB/Traktor/Banshee instead of doing IT/RB/Traktor and then duplicating it for Banshee.

Unmerged revisions

2990. By Daniel Schürmann

merged from lp:mixxx

2989. By Daniel Schürmann

merged from lp:mixxx

2988. By Daniel Schürmann

merged with lp:mixxx

2987. By Daniel Schürmann

merged banshee part from daschuers_trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.