Merge lp://qastaging/~dashua/light-themes/fix.lp.818541 into lp://qastaging/~ubuntu-art-pkg/light-themes/trunk

Proposed by James Schriver
Status: Merged
Merged at revision: 154
Proposed branch: lp://qastaging/~dashua/light-themes/fix.lp.818541
Merge into: lp://qastaging/~ubuntu-art-pkg/light-themes/trunk
Diff against target: 53 lines (+24/-0)
3 files modified
Ambiance/gtk-3.0/gtk-widgets.css (+8/-0)
Radiance/gtk-3.0/gtk-widgets.css (+8/-0)
debian/changelog (+8/-0)
To merge this branch: bzr merge lp://qastaging/~dashua/light-themes/fix.lp.818541
Reviewer Review Type Date Requested Status
Andrea Cimitan Pending
Review via email: mp+71490@code.qastaging.launchpad.net

Description of the change

@Cimi-This looks quite nice on Radiance as well and globally themes the spinner. This also looks good good in Nautilus in the infobar. Fixes the dark spinner viability on Ambiance in the sound menu.

To post a comment you must log in.
142. By James Schriver

[ James Schriver ]
* Ambiance/Radiance/gtk-3.0/gtk-widgets.css (LP: #818541)
  - Theme spinner to @selected_bg color

Revision history for this message
Andrea Cimitan (cimi) wrote :

I think it should be better to use dark everywhere, except where we really want it

Revision history for this message
James Schriver (dashua) wrote :

The spinner also loads in Gwibber too and a few other places on the dark toolbars. I guess we could specifically theme the spinner for this instances, but I think it is going to show up more on dark backgrounds than light.

Revision history for this message
James Schriver (dashua) wrote :

Empathy too.

Revision history for this message
Andrea Cimitan (cimi) wrote :

So, match it with .menu GtkSpinner, .primary-toolbar GtkSpinner

Revision history for this message
James Schriver (dashua) wrote :

Ok

Revision history for this message
Andrea Cimitan (cimi) wrote :

well, it requires touches to indicator sound, I'll manage it, thx anyway

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches