Merge lp://qastaging/~dave-terei/libmemcached/libmemcached into lp://qastaging/libmemcached
Proposed by
David Terei
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~dave-terei/libmemcached/libmemcached |
| Merge into: | lp://qastaging/libmemcached |
| Diff against target: |
899 lines (+403/-345) 8 files modified
bootstrap.sh (+10/-1) libmemcached-1.2/include.am (+1/-0) libmemcached-1.2/isasl.h (+92/-0) libmemcached-1.2/sasl.h (+1/-5) libmemcached-1.2/struct/sasl.h (+2/-6) libmemcached/include.am (+1/-0) libmemcached/sasl.cc (+104/-333) libmemcached/sasl_client.cc (+192/-0) |
| To merge this branch: | bzr merge lp://qastaging/~dave-terei/libmemcached/libmemcached |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tangent Trunk | Pending | ||
|
Review via email:
|
|||
Description of the change
Move to an internal SASL library taken from the membase guys. This removes the dependency on Cyrus SASL. It only supports PLAIN authentication, which seems fine as it's the only authentication mechanism other clients and memcached itself appears to support.
This enables SASL auth to be on by default which has great flow on effects for the community as right now most clients don't support SASL since they can't rely on libmemcached supporting it.
The removal of libsasl isn't complete (i.e., from configure scripts and build system) but I don't have a great grasp of that stuff. This is a initial step in the direction where the final stages of cleaning up should be trivial for someone who knows the code base.
To post a comment you must log in.
Revision history for this message
| David Terei (dave-terei) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Any update on this?