Merge lp://qastaging/~davidc3/unity-lens-music/rb-scope into lp://qastaging/unity-lens-music
Proposed by
David Callé
| Status: | Merged |
|---|---|
| Merged at revision: | 73 |
| Proposed branch: | lp://qastaging/~davidc3/unity-lens-music/rb-scope |
| Merge into: | lp://qastaging/unity-lens-music |
| Diff against target: |
293 lines (+222/-1) 6 files modified
configure.ac (+1/-0) src/Makefile.am (+3/-0) src/daemon.vala (+3/-0) src/rhythmbox-collection.vala (+104/-0) src/rhythmbox-scope.vala (+109/-0) src/track.vala (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~davidc3/unity-lens-music/rb-scope |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-03-07.
Description of the change
This branch adds a Rhythmbox scope, with basic search capabilities.
To post a comment you must log in.
Revision history for this message
| David Callé (davidc3) wrote | # |
Revision history for this message
| David Callé (davidc3) wrote | # |
Revision history for this message
| David Callé (davidc3) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
First of all, can you please fix:
Text conflict in src/simple-
208 + base.initialize ();
209 + Parser.init ();
Broken indentation.
248 + debug (@"Spawning rb '%s'", string.joinv (" ", exec));
Not a string template, please remove the @.