Merge lp://qastaging/~davidc3/unity-scope-calculator/glib-bindings-crash into lp://qastaging/unity-scope-calculator

Proposed by David Callé
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 43
Merged at revision: 43
Proposed branch: lp://qastaging/~davidc3/unity-scope-calculator/glib-bindings-crash
Merge into: lp://qastaging/unity-scope-calculator
Diff against target: 36 lines (+2/-14)
2 files modified
data/calculator.scope.in (+1/-1)
src/unity_calculator_daemon.py (+1/-13)
To merge this branch: bzr merge lp://qastaging/~davidc3/unity-scope-calculator/glib-bindings-crash
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+213213@code.qastaging.launchpad.net

Commit message

Don't crash Unity bindings when building results.

Description of the change

- Don't crash Unity bindings when building results.
- Add a calc keyword

Test plan : https://wiki.ubuntu.com/Process/Merges/TestPlan/unity-scope-calculator

 * Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes) Yes
 * Did you build your software in a clean sbuild/pbuilder chroot or ppa? Yes
 * Has your component "TestPlan” been executed successfully on desktop? Yes
 * If you changed the packaging (debian), did you subscribe a core-dev to this MP? N/A
 * If you changed the UI, did you subscribe the design-reviewers to this MP? N/A
 * What components might get impacted by your changes? None
 * Have you requested review by the teams of these owning components? N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looking good. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: