Photos

Merge lp://qastaging/~davidmhewitt/pantheon-photos/fix-1658467 into lp://qastaging/~pantheon-photos/pantheon-photos/trunk

  1. fix-1658467
  2. Merge into trunk
Proposed by David Hewitt
Status: Merged
Approved by: Corentin Noël
Approved revision: 3126
Merged at revision: 3140
Proposed branch: lp://qastaging/~davidmhewitt/pantheon-photos/fix-1658467
Merge into: lp://qastaging/~pantheon-photos/pantheon-photos/trunk
Diff against target: 119 lines (+29/-8)
2 files modified
src/Photo.vala (+13/-0)
src/direct/DirectPhotoPage.vala (+16/-8)
To merge this branch: bzr merge lp://qastaging/~davidmhewitt/pantheon-photos/fix-1658467
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+315314@code.qastaging.launchpad.net

Commit message

see if a file is writeable when closing and offer save as if the file is read only

Description of the change

Now tests to see if a file is writeable when closing the application and offers the save as option instead if the file is read only.

Also changed the behaviour slightly so that the application doesn't still close if there was a different error while saving.

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

There is a coding-style issue, you have to add a space before each parenthesis

review: Needs Fixing
lp://qastaging/~davidmhewitt/pantheon-photos/fix-1658467 updated
3125. By David Hewitt

Fixed code style issues

Revision history for this message
David Hewitt (davidmhewitt) wrote :

> There is a coding-style issue, you have to add a space before each parenthesis

Resolved

Revision history for this message
Corentin Noël (tintou) wrote :

Just two tiny things that I haven't see at first and we are good

lp://qastaging/~davidmhewitt/pantheon-photos/fix-1658467 updated
3126. By David Hewitt

Fixed hardcoded strings and ints and corrected whitespace

Revision history for this message
David Hewitt (davidmhewitt) wrote :

> Just two tiny things that I haven't see at first and we are good

Thanks Corentin, all good feedback. I've resolved the issues in the above commit.

Revision history for this message
Corentin Noël (tintou) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: