Indicator Date and Time

Merge lp://qastaging/~dbarth/indicator-datetime/adjust-title-notification-icons into lp://qastaging/indicator-datetime/15.10

  1. adjust-title-notification-icons
  2. Merge into trunk.15.10
Proposed by David Barth
Status: Merged
Merged at revision: 433
Proposed branch: lp://qastaging/~dbarth/indicator-datetime/adjust-title-notification-icons
Merge into: lp://qastaging/indicator-datetime/15.10
Diff against target: 28 lines (+9/-2)
1 file modified
src/snap.cpp (+9/-2)
To merge this branch: bzr merge lp://qastaging/~dbarth/indicator-datetime/adjust-title-notification-icons
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Indicator Applet Developers Pending
Review via email: mp+284911@code.qastaging.launchpad.net

Description of the change

This adjusts the notification title and icon for calendar reminders, according to the latest design guidelines.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:431
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/352/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/42/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/42/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/352/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM David :)

In fact I was thinking about this just yesterday when looking at James' comments in bug #1440111, but first I wanted to get indicator-datetime's codebase to the point where dual landings were possible again.

I've used this branch as the basis for <https://code.launchpad.net/~charlesk/indicator-datetime/lp-1440111-friendlier-calendar-items/+merge/284951>, stacking your branch on top of the unified-eds stack and fixing the tests + adding new icon & title tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches