Merge lp://qastaging/~dbarth/indicator-me/display-mode-gconf-key into lp://qastaging/indicator-me

Proposed by David Barth
Status: Merged
Merged at revision: not available
Proposed branch: lp://qastaging/~dbarth/indicator-me/display-mode-gconf-key
Merge into: lp://qastaging/indicator-me
Prerequisite: lp://qastaging/~dbarth/indicator-me/misc-fixes
Diff against target: 182 lines (+60/-50)
2 files modified
src/indicator-me.c (+11/-1)
src/me-service.c (+49/-49)
To merge this branch: bzr merge lp://qastaging/~dbarth/indicator-me/display-mode-gconf-key
Reviewer Review Type Date Requested Status
Ted Gould (community) Needs Information
Review via email: mp+21968@code.qastaging.launchpad.net

Description of the change

gconf key to be able to set the indicator display mode (username, realname, anonymous)

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

I can't find where you're emitting the User Changed signal. It seems like that should also be added into the DBus interface spec for the service.

Also, you need to add a GConf Schema for the GConf key.

review: Needs Information
Revision history for this message
David Barth (dbarth) wrote :

It's already in: I think you added that some time ago. It s in the xml definition file and also in me-service-dbus.c

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches