Merge lp://qastaging/~dbarth/indicator-me/gconf-switch into lp://qastaging/indicator-me

Proposed by David Barth
Status: Work in progress
Proposed branch: lp://qastaging/~dbarth/indicator-me/gconf-switch
Merge into: lp://qastaging/indicator-me
Diff against target: 49 lines (+11/-9)
2 files modified
src/indicator-me.c (+4/-7)
src/me-service.c (+7/-2)
To merge this branch: bzr merge lp://qastaging/~dbarth/indicator-me/gconf-switch
Reviewer Review Type Date Requested Status
Ted Gould (community) Needs Fixing
Review via email: mp+35094@code.qastaging.launchpad.net

Description of the change

Clean up the gconf option to control the appearance of the panel indicator

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

the change is buggy since you don't migrate the key value, better to wait next cycle and the gsettings updates to migrate the key and value

Revision history for this message
Ted Gould (ted) wrote :

From Seb's comment I'm marking this as "Needs Fixing" -- oh, and I agree with him, GSettings for the win!

review: Needs Fixing

Unmerged revisions

106. By David Barth

gconf namespace switched to /apps/indicator-me/display to be consistent with other indicators; also don't hide the username label in anonymous mode to prevent the indicator from disappearing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches