Online Accounts setup for Ubuntu Touch

Merge lp://qastaging/~dbarth/ubuntu-system-settings-online-accounts/improve-auth-page-layout into lp://qastaging/ubuntu-system-settings-online-accounts

  1. improve-auth-page-layout
  2. Merge into trunk
Proposed by David Barth
Status: Merged
Approved by: David Barth
Approved revision: 195
Merged at revision: 197
Proposed branch: lp://qastaging/~dbarth/ubuntu-system-settings-online-accounts/improve-auth-page-layout
Merge into: lp://qastaging/ubuntu-system-settings-online-accounts
Diff against target: 64 lines (+21/-18)
1 file modified
online-accounts-ui/qml/AuthorizationPage.qml (+21/-18)
To merge this branch: bzr merge lp://qastaging/~dbarth/ubuntu-system-settings-online-accounts/improve-auth-page-layout
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alberto Mardegan (community) Approve
Review via email: mp+237395@code.qastaging.launchpad.net

Commit message

Improve the layout of the authorization page

Description of the change

Improve the layout of the authorization page

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

See inline comments.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:194
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/172/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5579/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-amd64-ci/65
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-i386-ci/65
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5272/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6831
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6831/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14249

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/172/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~dbarth/ubuntu-system-settings-online-accounts/improve-auth-page-layout updated
195. By David Barth

let users create an account from this dialog

Revision history for this message
Alberto Mardegan (mardy) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:195
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/174/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5665
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-i386-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5342
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6917
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6917/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14334

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/174/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches