webapps-demo

Merge lp://qastaging/~dbarth/webapps-demo/click-packages into lp://qastaging/webapps-demo

click-packages
Merge into trunk

Proposed by David Barth on 2013-10-10

Status:

Merged

Approved by:

Alexandre Abreu on 2013-10-15

Approved revision:

Merged at revision:

Proposed branch:

lp://qastaging/~dbarth/webapps-demo/click-packages

Merge into:

lp://qastaging/webapps-demo

Diff against target:

77 lines (+20/-4)

6 files modified

webapp-gmail/manifest.json (+1/-1)
webapp-gmail/unity-webapps-gmail/GMail.user.js (+1/-0)
webapp-gmail/unity-webapps-gmail/manifest.json (+15/-0)
webapp-gmail/webapp-gmail.desktop (+1/-1)
webapp-twitter/manifest.json (+1/-1)
webapp-twitter/webapp-twitter.desktop (+1/-1)

To merge this branch:

bzr merge lp://qastaging/~dbarth/webapps-demo/click-packages

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alexandre Abreu (community)		2013-10-10	Approve on 2013-10-15
PS Jenkins bot	continuous-integration		Approve on 2013-10-11
Review via email: mp+190481@code.qastaging.launchpad.net

Commit message

Fixes a major regression with Gmail.
Helps skip the Android App landing page on the path to twitter signon.

Description of the change

Fixes a major regression with Gmail.
Helps skip the Android App landing page on the path to twitter signon.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-10-10:

PASSED: Continuous integration, rev:64
http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/25/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/8
SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/8

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/webapps-demo-ci/25/rebuild

review: Approve (continuous-integration)

lp://qastaging/~dbarth/webapps-demo/click-packages updated on 2013-10-10

65. By David Barth on 2013-10-10: gmail, fixed by alex-abreu

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-10-10:

PASSED: Continuous integration, rev:65
http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/26/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/9
SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/9

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/webapps-demo-ci/26/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2013-10-10:

you need a common/ folder at the root level ... a bit artificial but required by unity-webapps-qml, so just add an empty common/ folder at the same top level as unity-webapps-gmail

review: Needs Fixing

Revision history for this message

Alexandre Abreu (abreu-alexandre) wrote on 2013-10-10:

L48: duplicated --webapp argument, it should read:

webbrowser-app --enable-back-forward --webappModelSearchPath=. --webapp='R01haWwNCg=='

(you don't need the url, it will be pulled from the manifest.json file)

lp://qastaging/~dbarth/webapps-demo/click-packages updated on 2013-10-11