Zeitgeist Extensions

Merge lp://qastaging/~dbarth/zeitgeist-extensions/fts-cjk-support into lp://qastaging/zeitgeist-extensions

  1. fts-cjk-support
  2. Merge into trunk
Proposed by David Barth
Status: Merged
Merged at revision: 58
Proposed branch: lp://qastaging/~dbarth/zeitgeist-extensions/fts-cjk-support
Merge into: lp://qastaging/zeitgeist-extensions
Diff against target: 26 lines (+9/-0)
1 file modified
fts/fts.py (+9/-0)
To merge this branch: bzr merge lp://qastaging/~dbarth/zeitgeist-extensions/fts-cjk-support
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen Approve
David Barth (community) Needs Resubmitting
Michael Vogt Pending
Review via email: mp+72903@code.qastaging.launchpad.net

Description of the change

Add support for the new CJK tokenizer in Xapian

To post a comment you must log in.
lp://qastaging/~dbarth/zeitgeist-extensions/fts-cjk-support updated
59. By David Barth

Upgrade by forcing a reindex for older databases

Revision history for this message
David Barth (dbarth) wrote :

For reference, the upstream recommendation for activating the CJK tokenizer. This is in the perspective of future optional tokenizer, and to avoid an API change while a new official release is not ready yet.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

The condition os.environ['XAPIAN_CJK_NGRAM'] == 1 will always be false, use "1". But maybe we really want to check != None since I thin I recall Olly mentioning that Xapian activates CJK if the envvar is set (disregarding value).

Stylistically we use double quotes " and not single quotes ' for strings.

review: Needs Fixing
Revision history for this message
David Barth (dbarth) wrote :

This should be better now

review: Needs Resubmitting
lp://qastaging/~dbarth/zeitgeist-extensions/fts-cjk-support updated
60. By David Barth

smarter test and better style

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I merged this with some slight tweaks. Now trying to convince the test harness to run :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: