Launchpad itself

Merge lp://qastaging/~deryck/launchpad/comment-button-capitalization-415253 into lp://qastaging/launchpad

  1. comment-button-capitalization-415253
  2. Merge into devel
Proposed by Deryck Hodge
Status: Merged
Merged at revision: not available
Proposed branch: lp://qastaging/~deryck/launchpad/comment-button-capitalization-415253
Merge into: lp://qastaging/launchpad
Diff against target: None lines
To merge this branch: bzr merge lp://qastaging/~deryck/launchpad/comment-button-capitalization-415253
Reviewer Review Type Date Requested Status
Abel Deuring (community) Approve
Review via email: mp+10848@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

This is a clean up branch to change 'Post comment' to 'Post Comment'.
See bug 415253.

This was undertaken while doing some template updates for 3.0, but I
moved it to its own branch given all the lines of tests that needed
updating.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/stories/bugattachments/xx-delete-bug-attachment.txt
  lib/lp/bugs/stories/bugattachments/xx-display-filesize-attachment.txt
  lib/lp/bugs/browser/bugmessage.py
  lib/lp/bugs/stories/bugs/80-add-comment.txt
  lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt
  lib/lp/bugs/stories/bugs/xx-bug-hidden-comments.txt
  lib/lp/bugs/stories/bugs/xx-bug-activity.txt
  lib/lp/bugs/stories/bugattachments/40-search-bug-attachments.txt
  lib/lp/bugs/stories/bugs/xx-bug-comment-attach-file.txt
  lib/lp/bugs/stories/bugs/xx-add-comment-with-bugwatch-and-cve.txt
  lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt
  lib/lp/bugs/stories/bugattachments/10-add-bug-attachment.txt

lib/lp/bugs/stories/bugs/xx-add-comment-distribution-no-current-release.txt

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Deryck,

Thanks for fixing this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/bugmessage.py'
2--- lib/lp/bugs/browser/bugmessage.py 2009-08-20 02:46:12 +0000
3+++ lib/lp/bugs/browser/bugmessage.py 2009-08-28 14:31:15 +0000
4@@ -54,7 +54,7 @@
5 self.addError("Either a comment or attachment "
6 "must be provided.")
7
8- @action(u"Post comment", name='save')
9+ @action(u"Post Comment", name='save')
10 def save_action(self, action, data):
11 """Add the comment and/or attachment."""
12
13
14=== modified file 'lib/lp/bugs/stories/bugattachments/10-add-bug-attachment.txt'
15--- lib/lp/bugs/stories/bugattachments/10-add-bug-attachment.txt 2009-08-06 14:55:50 +0000
16+++ lib/lp/bugs/stories/bugattachments/10-add-bug-attachment.txt 2009-08-28 14:31:15 +0000
17@@ -25,7 +25,7 @@
18 >>> user_browser.getControl('Description').value = ' Some information '
19 >>> user_browser.getControl(
20 ... name="field.comment").value = 'Added some information'
21- >>> user_browser.getControl('Post comment').click()
22+ >>> user_browser.getControl('Post Comment').click()
23
24 After we added the attachment, we get redirected to the bug page.
25
26@@ -61,7 +61,7 @@
27 ... bar_file, 'text/plain', 'bar.txt')
28 >>> user_browser.getControl('Description').value = ''
29 >>> user_browser.getControl(name="field.comment").value = ''
30- >>> user_browser.getControl('Post comment').click()
31+ >>> user_browser.getControl('Post Comment').click()
32 >>> user_browser.url
33 'http://bugs.launchpad.dev/firefox/+bug/1'
34
35
36=== modified file 'lib/lp/bugs/stories/bugattachments/40-search-bug-attachments.txt'
37--- lib/lp/bugs/stories/bugattachments/40-search-bug-attachments.txt 2009-08-06 14:55:50 +0000
38+++ lib/lp/bugs/stories/bugattachments/40-search-bug-attachments.txt 2009-08-28 14:31:15 +0000
39@@ -10,7 +10,7 @@
40 >>> user_browser.getControl("Description").value = "Some information."
41 >>> user_browser.getControl(
42 ... name="field.comment").value = "Added some information."
43- >>> user_browser.getControl("Post comment").click()
44+ >>> user_browser.getControl("Post Comment").click()
45
46 And a patch...
47
48@@ -24,7 +24,7 @@
49 >>> user_browser.getControl("Description").value = "A patch."
50 >>> user_browser.getControl(
51 ... name="field.comment").value = "This patch fixes the bug."
52- >>> user_browser.getControl("Post comment").click()
53+ >>> user_browser.getControl("Post Comment").click()
54
55 And another patch...
56
57@@ -37,7 +37,7 @@
58 >>> user_browser.getControl("Description").value = "A patch."
59 >>> user_browser.getControl(
60 ... name="field.comment").value = "This patch fixes the bug."
61- >>> user_browser.getControl("Post comment").click()
62+ >>> user_browser.getControl("Post Comment").click()
63
64 And now we'll search for patches for firefox bugs.
65
66
67=== modified file 'lib/lp/bugs/stories/bugattachments/xx-delete-bug-attachment.txt'
68--- lib/lp/bugs/stories/bugattachments/xx-delete-bug-attachment.txt 2009-08-06 14:55:50 +0000
69+++ lib/lp/bugs/stories/bugattachments/xx-delete-bug-attachment.txt 2009-08-28 14:31:15 +0000
70@@ -10,7 +10,7 @@
71 >>> user_browser.getControl('Attachment').add_file(
72 ... foo_file, 'text/plain', 'foo.txt')
73 >>> user_browser.getControl('Description').value = 'Great deal'
74- >>> user_browser.getControl('Post comment').click()
75+ >>> user_browser.getControl('Post Comment').click()
76
77 The attachment is now visible on the bug page.
78
79
80=== modified file 'lib/lp/bugs/stories/bugattachments/xx-display-filesize-attachment.txt'
81--- lib/lp/bugs/stories/bugattachments/xx-display-filesize-attachment.txt 2009-08-07 08:56:22 +0000
82+++ lib/lp/bugs/stories/bugattachments/xx-display-filesize-attachment.txt 2009-08-28 14:31:15 +0000
83@@ -13,7 +13,7 @@
84 ... foo_file, "text/plain", "foo.txt")
85 >>> user_browser.getControl("Description").value = "description text"
86 >>> user_browser.getControl(name="field.comment").value = "comment comment"
87- >>> user_browser.getControl("Post comment").click()
88+ >>> user_browser.getControl("Post Comment").click()
89 >>> user_browser.url
90 'http://bugs.launchpad.dev/firefox/+bug/1'
91
92@@ -44,7 +44,7 @@
93 ... foo_file, "text/plain", "foo.txt")
94 >>> user_browser.getControl("Description").value = "description text"
95 >>> user_browser.getControl(name="field.comment").value = "comment comment"
96- >>> user_browser.getControl("Post comment").click()
97+ >>> user_browser.getControl("Post Comment").click()
98 >>> user_browser.url
99 'http://bugs.launchpad.dev/firefox/+bug/1'
100
101
102=== modified file 'lib/lp/bugs/stories/bugs/80-add-comment.txt'
103--- lib/lp/bugs/stories/bugs/80-add-comment.txt 2009-08-06 13:51:38 +0000
104+++ lib/lp/bugs/stories/bugs/80-add-comment.txt 2009-08-28 14:31:15 +0000
105@@ -17,7 +17,7 @@
106 ... 'http://localhost/debian/+source/mozilla-firefox/+bug/2')
107 >>> user_browser.getControl(name='field.comment').value = (
108 ... 'This is a test comment.')
109- >>> user_browser.getControl('Post comment', index=-1).click()
110+ >>> user_browser.getControl('Post Comment', index=-1).click()
111
112 >>> user_browser.url
113 'http://bugs.launchpad.dev/debian/+source/mozilla-firefox/+bug/2'
114
115=== modified file 'lib/lp/bugs/stories/bugs/xx-add-comment-distribution-no-current-release.txt'
116--- lib/lp/bugs/stories/bugs/xx-add-comment-distribution-no-current-release.txt 2009-08-06 13:51:38 +0000
117+++ lib/lp/bugs/stories/bugs/xx-add-comment-distribution-no-current-release.txt 2009-08-28 14:31:15 +0000
118@@ -12,7 +12,7 @@
119 'http://bugs.launchpad.dev/gentoo/+bug/...'
120
121 >>> user_browser.getControl(name='field.comment').value = 'A new comment.'
122- >>> user_browser.getControl('Post comment', index=-1).click()
123+ >>> user_browser.getControl('Post Comment', index=-1).click()
124
125 >>> for comment_div in find_tags_by_class(
126 ... user_browser.contents, 'boardCommentBody'):
127
128=== modified file 'lib/lp/bugs/stories/bugs/xx-add-comment-with-bugwatch-and-cve.txt'
129--- lib/lp/bugs/stories/bugs/xx-add-comment-with-bugwatch-and-cve.txt 2009-08-06 13:51:38 +0000
130+++ lib/lp/bugs/stories/bugs/xx-add-comment-with-bugwatch-and-cve.txt 2009-08-28 14:31:15 +0000
131@@ -11,7 +11,7 @@
132 ... described here http://some.bugzilla/show_bug.cgi?id=9876
133 ... See also CVE-1991-9911
134 ... ''')
135- >>> user_browser.getControl('Post comment', index=-1).click()
136+ >>> user_browser.getControl('Post Comment', index=-1).click()
137
138 >>> user_browser.url
139 'http://bugs.launchpad.dev/debian/+source/mozilla-firefox/+bug/1'
140@@ -40,7 +40,7 @@
141 ... u'\xabhttps://answers.launchpad.net/ubuntu\xbb is not a linked bug '
142 ... u'but https://bugzilla.example.org/show_bug.cgi?id=1235555 '
143 ... u'is.'.encode('utf-8'))
144- >>> user_browser.getControl('Post comment', index=-1).click()
145+ >>> user_browser.getControl('Post Comment', index=-1).click()
146 >>> user_browser.url
147 'http://bugs.launchpad.dev/debian/+source/mozilla-firefox/+bug/1'
148
149
150=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-activity.txt'
151--- lib/lp/bugs/stories/bugs/xx-bug-activity.txt 2009-08-27 08:32:39 +0000
152+++ lib/lp/bugs/stories/bugs/xx-bug-activity.txt 2009-08-28 14:31:15 +0000
153@@ -53,7 +53,7 @@
154 ... 'http://bugs.launchpad.dev/redfish/+bug/15/+addcomment')
155 >>> user_browser.getControl(name='field.comment').value = (
156 ... "Here's a comment for testing, like.")
157- >>> user_browser.getControl('Post comment').click()
158+ >>> user_browser.getControl('Post Comment').click()
159 >>> print_comments(user_browser.contents)
160 Bug Watch Updater
161 on 2007-12-18
162
163=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-comment-attach-file.txt'
164--- lib/lp/bugs/stories/bugs/xx-bug-comment-attach-file.txt 2009-08-07 08:56:22 +0000
165+++ lib/lp/bugs/stories/bugs/xx-bug-comment-attach-file.txt 2009-08-28 14:31:15 +0000
166@@ -15,7 +15,7 @@
167 >>> user_browser.open(
168 ... "http://bugs.launchpad.dev/firefox/+bug/1/+addcomment-form")
169 >>> user_browser.getControl(name='field.comment').value = "a test comment"
170- >>> user_browser.getControl("Post comment").click()
171+ >>> user_browser.getControl("Post Comment").click()
172
173 >>> print user_browser.url
174 http://bugs.launchpad.dev/firefox/+bug/1
175@@ -31,7 +31,7 @@
176 ... "http://bugs.launchpad.dev/firefox/+bug/1/+addcomment-form")
177 >>> user_browser.getControl("Attachment").add_file(
178 ... StringIO("a test file"), "text/plain", "foo.txt")
179- >>> user_browser.getControl("Post comment").click()
180+ >>> user_browser.getControl("Post Comment").click()
181
182 >>> get_feedback_messages(user_browser.contents)
183 [u'Attachment foo.txt added to bug.']
184@@ -45,7 +45,7 @@
185 >>> user_browser.getControl("Attachment").add_file(
186 ... StringIO("some file"), "text/plain", "bar.txt")
187 >>> user_browser.getControl("Description").value = "some file"
188- >>> user_browser.getControl("Post comment").click()
189+ >>> user_browser.getControl("Post Comment").click()
190
191 >>> print user_browser.url
192 http://bugs.launchpad.dev/firefox/+bug/1
193@@ -59,7 +59,7 @@
194 ... "http://bugs.launchpad.dev/firefox/+bug/1/+addcomment-form")
195 >>> user_browser.getControl("Attachment").add_file(
196 ... StringIO(""), "text/plain", "foo.txt")
197- >>> user_browser.getControl("Post comment").click()
198+ >>> user_browser.getControl("Post Comment").click()
199
200 >>> print user_browser.url
201 http://bugs.launchpad.dev/firefox/+bug/1/+addcomment
202@@ -81,7 +81,7 @@
203 ... "http://bugs.launchpad.dev/firefox/+bug/1/+addcomment-form")
204 >>> user_browser.getControl("Attachment").add_file(
205 ... StringIO("x"*1025), "text/plain", "foo.txt")
206- >>> user_browser.getControl("Post comment").click()
207+ >>> user_browser.getControl("Post Comment").click()
208
209 >>> for msg in get_feedback_messages(user_browser.contents):
210 ... print msg
211@@ -95,7 +95,7 @@
212 >>> user_browser.getControl("Attachment").add_file(
213 ... StringIO("a test file"), "text/plain", "foo.txt")
214 >>> user_browser.getControl("Description").value = "some file"
215- >>> user_browser.getControl("Post comment").click()
216+ >>> user_browser.getControl("Post Comment").click()
217
218 >>> print user_browser.url
219 http://bugs.launchpad.dev/firefox/+bug/1
220
221=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt'
222--- lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt 2009-08-06 13:51:38 +0000
223+++ lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt 2009-08-28 14:31:15 +0000
224@@ -107,7 +107,7 @@
225 ... "T2PIWy0CUJsX8RXSt/M51WE=\n"
226 ... "=J2S5\n"
227 ... "-----END PGP SIGNATURE-----\n")
228- >>> user_browser.getControl('Post comment', index=-1).click()
229+ >>> user_browser.getControl('Post Comment', index=-1).click()
230
231 No Privileges Person is authenticated in user_browser, so he can see
232 email addresses in messages.
233
234=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-hidden-comments.txt'
235--- lib/lp/bugs/stories/bugs/xx-bug-hidden-comments.txt 2009-08-06 13:51:38 +0000
236+++ lib/lp/bugs/stories/bugs/xx-bug-hidden-comments.txt 2009-08-28 14:31:15 +0000
237@@ -9,7 +9,7 @@
238 ... '/jokosher/+bug/11')
239 >>> user_browser.getControl(name='field.comment').value = (
240 ... 'This comment will not visible when the test completes.')
241- >>> user_browser.getControl('Post comment', index=-1).click()
242+ >>> user_browser.getControl('Post Comment', index=-1).click()
243 >>> main_content = find_main_content(user_browser.contents)
244 >>> new_comment = main_content('div', 'boardCommentBody')[-1]
245 >>> new_comment_text = extract_text(new_comment.div)
246
247=== modified file 'lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt'
248--- lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt 2009-08-06 13:51:38 +0000
249+++ lib/lp/bugs/stories/bugs/xx-incomplete-bugs.txt 2009-08-28 14:31:15 +0000
250@@ -49,7 +49,7 @@
251 >>> user_browser.open('http://bugs.launchpad.dev/jokosher/+bug/11')
252 >>> user_browser.getControl(name='field.comment').value = (
253 ... 'More information here.')
254- >>> user_browser.getControl('Post comment').click()
255+ >>> user_browser.getControl('Post Comment').click()
256
257 >>> import transaction
258 >>> transaction.commit()
259@@ -188,7 +188,7 @@
260
261 >>> user_browser.getLink('Make Jokosher use autoaudiosink').click()
262 >>> user_browser.getControl(name='field.comment').value = "bump"
263- >>> user_browser.getControl('Post comment').click()
264+ >>> user_browser.getControl('Post Comment').click()
265 >>> user_browser.getLink('Bugs').click()
266 >>> user_browser.getLink('incomplete bugs can expire').click()
267 >>> contents = find_main_content(user_browser.contents)