Code review comment for lp://qastaging/~deryck/launchpad/dupe-portlet-click-fail

Revision history for this message
Deryck Hodge (deryck) wrote :

This is a fix for bug #482379. The unsubscribe icons in subscription
portlets were not being hooked up for handling onclick events. So
people could not unsubscribe inline.

This happened because of an update to load duplicate subscriptions from
a second XHR request (the direct subscribers load in the first XHR). So
this branch creates a new custom event to fire after the duplicate
subscriber list has loaded. If that load fails, a failure event fires
to make sure any unsub icons for direct subscribers are still hooked up.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/javascript/bugs/bugtask-index.js
  lib/lp/bugs/windmill/tests/test_bug_inline_subscriber.py

== JSLint notices ==
jslint: No problem found in
'/data/home/deryck/canonical/lp-branches/dupe-portlet-click-fail/lib/canonical/launchpad/javascript/bugs/bugtask-index.js'.

jslint: 1 file to lint.

« Back to merge proposal