Merge lp://qastaging/~desrt/indicator-appmenu/hud-performance into lp://qastaging/indicator-appmenu/0.4
Proposed by
desrt
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Charles Kerr | ||||||||
| Approved revision: | 213 | ||||||||
| Merged at revision: | 197 | ||||||||
| Proposed branch: | lp://qastaging/~desrt/indicator-appmenu/hud-performance | ||||||||
| Merge into: | lp://qastaging/indicator-appmenu/0.4 | ||||||||
| Diff against target: |
2576 lines (+1367/-705) 34 files modified
configure.ac (+1/-1) data/Makefile.am (+5/-13) data/com.canonical.indicator.appmenu.gschema.xml (+18/-0) data/com.canonical.indicator.appmenu.gschema.xml.in (+0/-15) data/com.canonical.indicator.appmenu.hud.gschema.xml (+16/-0) data/com.canonical.indicator.appmenu.hud.gschema.xml.in (+0/-14) data/com.canonical.indicator.appmenu.hud.search.gschema.xml (+72/-0) data/com.canonical.indicator.appmenu.hud.search.gschema.xml.in (+0/-90) po/POTFILES.in (+4/-4) src/Makefile.am (+2/-2) src/distance.c (+0/-415) src/distance.h (+0/-33) src/hudappindicatorsource.c (+4/-4) src/huddbusmenucollector.c (+3/-3) src/huddebugsource.c (+3/-3) src/hudindicatorsource.c (+3/-3) src/huditem.c (+11/-0) src/huditem.h (+2/-1) src/hudmenumodelcollector.c (+3/-3) src/hudquery.c (+9/-1) src/hudresult.c (+13/-40) src/hudresult.h (+12/-12) src/hudsettings.c (+4/-15) src/hudsettings.h (+1/-4) src/hudsource.c (+3/-3) src/hudsource.h (+13/-13) src/hudsourcelist.c (+3/-3) src/hudtoken.c (+394/-0) src/hudtoken.h (+40/-0) src/hudwindowsource.c (+9/-4) tests/Makefile.am (+18/-0) tests/hud-performance.c (+279/-0) tests/test-distance.c (+58/-6) tests/word-list.h (+364/-0) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~desrt/indicator-appmenu/hud-performance | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Improve hud-service performance and search result quality by substantially reworking the core distance algorithm and the needle/haystack assignment algorithm.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
A couple of non-critical comments:
* Next time please use move for things like the schemas as then diffs are tracked on them which makes reviewing them much easier.
* I think the "magic 32" should probably be a #define just so that if someone changes it it will be changed everywhere. For instance, changing it in _new() could cause an assert failure further down the road.
* A comment on hud_token_
* Love the test :-)