Compiz

Merge lp://qastaging/~dgadomski/compiz/remember-focus into lp://qastaging/compiz/0.9.12

  1. remember-focus
  2. Merge into 0.9.12
Proposed by Dariusz Gadomski
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 3895
Merged at revision: 3891
Proposed branch: lp://qastaging/~dgadomski/compiz/remember-focus
Merge into: lp://qastaging/compiz/0.9.12
Diff against target: 127 lines (+60/-0)
3 files modified
metadata/core.xml.in (+5/-0)
src/privatescreen.h (+17/-0)
src/screen.cpp (+38/-0)
To merge this branch: bzr merge lp://qastaging/~dgadomski/compiz/remember-focus
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+236735@code.qastaging.launchpad.net

Commit message

CompScreen: Save focused window id before changing viewport.

This allows to restore focus after returning to one of the previous viewport positions.
Introduces a new setting (General Options / Focus & Raise Behaviour / Remember Focus)

Description of the change

Save focused window id before changing viewport. This allows to restore focus after returning to one of the previous viewport positions.

Introduces a new setting (General Options / Focus & Raise Behaviour / Remember Focus)

Fixes: 1125442

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Just a few inline comments...

One thing on style, make sure that you follow the compiz style, for example, adding one space between the function name and the parenthesis (such as "function ();").

Also, the indentation should be (a little annoying, I know :P):
1st level: 4 spaces, 2nd level 1 tab (set at 8 spaces), 3rd level: 1 tab + 4 spaces, 4th level: 2 tabs, and so on... :)

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Thanks Marco, I will improve the fix.

Revision history for this message
Dariusz Gadomski (dgadomski) :
lp://qastaging/~dgadomski/compiz/remember-focus updated
3891. By Dariusz Gadomski

Minor refactoring and style changes to remember-focus.

3892. By Dariusz Gadomski

Applied style fixes for PointCompare.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, just few more style fixes.

I was thinking that probably it would be better to rename the functions/members so that they mention the WS or VP (as you prefer) in their name, so that we have saveViewPortFocus() and findViewPortFocusCandidate()...

lp://qastaging/~dgadomski/compiz/remember-focus updated
3893. By Dariusz Gadomski

remember_vp_focus is set to true by default.
Added 'viewport' to method names.
Corrected indentation.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
lp://qastaging/~dgadomski/compiz/remember-focus updated
3894. By Dariusz Gadomski

Erasing saved focus even if window was not found.

3895. By Dariusz Gadomski

Simplified findViewportFocusCandidate.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Cool, looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches