Ubuntu Calculator App

Merge lp://qastaging/~dgadomski/ubuntu-calculator-app/relative-time-formatting into lp://qastaging/~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

  1. relative-time-formatting
  2. Merge into old_trunk
Proposed by Dariusz Gadomski
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 117
Merged at revision: 118
Proposed branch: lp://qastaging/~dgadomski/ubuntu-calculator-app/relative-time-formatting
Merge into: lp://qastaging/~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk
Diff against target: 213 lines (+104/-60)
3 files modified
Simple/SimplePage.qml (+3/-2)
Storage.qml (+2/-58)
dateutils.js (+99/-0)
To merge this branch: bzr merge lp://qastaging/~dgadomski/ubuntu-calculator-app/relative-time-formatting
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Gustavo Pichorim Boiko (community) Approve
Riccardo Padovani Approve
David Planella Pending
Review via email: mp+177651@code.qastaging.launchpad.net

Commit message

Reusing relative time formatting implemented for ubuntu-rssreader-app.

Description of the change

As agreed with David Planella I have prepared a common framework for relative time formatting for the rssreader-app (https://code.launchpad.net/~dgadomski/ubuntu-rssreader-app/relative-time-formatting/+merge/176435) and calculator-app.

Please take time to review it. Thanks.

To post a comment you must log in.
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Looks good, thank you very much for your contribute Dariusz!

review: Approve
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

You're welcome. I'm glad to help.

I have just one question: this merge request remains in Needs Review state. Does it still need an approval from someone else?

Thanks.

Revision history for this message
Mihir Soni (mihirsoni) wrote :

Jenkins Bot will automatically merge your request..you don't need to do it manually :)

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Yes, someone (you?) asks explicitly to dpm to review it. As far as I know David will return next week, so we have to wait

Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

Oh, I see. I added him because providing a consistent implementations for both: rssreader and calculator was his idea. Thanks for the info. Let's wait for him :)

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

I am verifying why the jenkins' continuous integration didn't run on this branch, after CI passes, I will approve (as the code looks good), and top approve it so that it gets merged.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

So, CI won't run for this MR, and as the code looks good, I'll approve it.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches