Merge lp://qastaging/~dgadomski/ubuntu-rssreader-app/formatRelativeTime-uses-seconds into lp://qastaging/~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Proposed by
Dariusz Gadomski
| Status: | Merged |
|---|---|
| Approved by: | Joey Chan |
| Approved revision: | 57 |
| Merged at revision: | 57 |
| Proposed branch: | lp://qastaging/~dgadomski/ubuntu-rssreader-app/formatRelativeTime-uses-seconds |
| Merge into: | lp://qastaging/~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk |
| Diff against target: |
114 lines (+13/-10) 7 files modified
RssFeedPage.qml (+1/-1) article_items/ArticleFullImg.qml (+1/-1) article_items/ArticleOneImgA.qml (+1/-1) article_items/ArticleTextA.qml (+1/-1) article_items/ArticleTextB.qml (+1/-1) dateutils.js (+7/-4) listview/ListModePage.qml (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~dgadomski/ubuntu-rssreader-app/formatRelativeTime-uses-seconds |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Joey Chan | Approve | ||
|
Review via email:
|
|||
Commit message
Adjusted formatRelativeTime to handle date expressed as seconds.
Description of the change
I have changed to formatRelativeTime function to take an integer argument interpreted as number of seconds since 1970-01-01.
Additionally function parseDate has been altered to return a number of seconds since 1970-01-01 for a given date.
All invocations in QML has been replaced with the following scheme:
DateUtils.
To post a comment you must log in.
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you :)