Merge ~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:unblock-sigusr1 into ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic

Proposed by Dariusz Gadomski
Status: Merged
Merge reported by: Iain Lane
Merged at revision: ce4a95af00d3f2174bf10827e75b54bf5fde2154
Proposed branch: ~dgadomski/ubuntu/+source/gdm3/+git/lp1782152:unblock-sigusr1
Merge into: ~ubuntu-desktop/ubuntu/+source/gdm3:ubuntu/bionic
Diff against target: 240 lines (+115/-40)
3 files modified
debian/patches/series (+1/-0)
debian/patches/ubuntu_nvidia_prime.patch (+46/-40)
debian/patches/unblock-sigusr1.patch (+68/-0)
Reviewer Review Type Date Requested Status
Iain Lane Needs Fixing
Review via email: mp+353089@code.qastaging.launchpad.net

Commit message

[ Alberto Milone ]
  * ubuntu_nvidia_prime.patch:
    - Run scripts for Prime before and after Gdm sessions (LP: #1778011).
[ Dariusz Gadomski ]
  * debian/patches/unblock-sigusr1.patch:
    - Unblock SIGUSR1 before PAM. (LP: #1782152)

Description of the change

Rebased on top of 3.28.3.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

You don't need unblock-sigusr1.patch any more. It's in this release:

Applying patch unblock-sigusr1.patch
patching file daemon/gdm-session-worker-job.c
Hunk #1 FAILED at 117.
1 out of 1 hunk FAILED -- rejects in file daemon/gdm-session-worker-job.c
patching file daemon/gdm-session-worker.c
Hunk #1 FAILED at 2025.
Hunk #2 FAILED at 2147.
2 out of 2 hunks FAILED -- rejects in file daemon/gdm-session-worker.c
Patch unblock-sigusr1.patch can be reverse-applied

Have you tested this update?

review: Needs Fixing
Revision history for this message
Iain Lane (laney) wrote :

Please make sure to update the changelog too

Revision history for this message
Iain Lane (laney) wrote :

I just pushed this branch without ce4a95af00d3f2174bf10827e75b54bf5fde2154 and added a changelog entry for that change on top. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches