Unity Settings Daemon

Merge lp://qastaging/~dgadomski/unity-settings-daemon/lp1755490 into lp://qastaging/unity-settings-daemon

  1. lp1755490
  2. Merge into trunk
Proposed by Dariusz Gadomski
Status: Merged
Merged at revision: 4183
Proposed branch: lp://qastaging/~dgadomski/unity-settings-daemon/lp1755490
Merge into: lp://qastaging/unity-settings-daemon
Diff against target: 62 lines (+23/-7)
1 file modified
gnome-settings-daemon/display-name.c (+23/-7)
To merge this branch: bzr merge lp://qastaging/~dgadomski/unity-settings-daemon/lp1755490
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+346885@code.qastaging.launchpad.net

Commit message

Handle incorrect EDID data for many LG TVs.

Display the model name instead of calculating incorrect diagonal.

Description of the change

I'm aware it's a cosmetic thing, but I've been made aware of this bug by a group of users who care about these kind of details and they believe this impacts the overall impression of quality.

To post a comment you must log in.
lp://qastaging/~dgadomski/unity-settings-daemon/lp1755490 updated
4183. By Dariusz Gadomski

Not only LG devices report incorrect width & height.

According to upstream bug comment [1].

[1] https://gitlab.gnome.org/GNOME/gnome-control-center/issues/99

4184. By Dariusz Gadomski

Handle more than one set of aspect values.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Is that still an issue in current Ubuntu version and in upstream GNOME? The upstream issue you mentioned in the commit is still open and you said you would poke on the gnome-shell side of things to fix in the current version, did you do that?

That doesn't block the issue to get fixed in u-s-d but it would be nice also to give some explanation about the logic used there

review: Needs Information
Revision history for this message
Dariusz Gadomski (dgadomski) wrote :

It needs a separate fix for mutter [1]. I've prepared a patch for it [2]. It has been accepted, but I was told to wait until 3.32 due to introducing a new translation string.

[1] https://gitlab.gnome.org/GNOME/mutter/issues/292
[2] https://gitlab.gnome.org/GNOME/mutter/merge_requests/223

Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches