Snapcraft

Merge lp://qastaging/~dholbach/snapcraft/1498347 into lp://qastaging/~snappy-dev/snapcraft/core

  1. 1498347
  2. Merge into core
Proposed by Daniel Holbach
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 193
Merged at revision: 195
Proposed branch: lp://qastaging/~dholbach/snapcraft/1498347
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 24 lines (+7/-3)
1 file modified
examples/godd/snapcraft.yaml (+7/-3)
To merge this branch: bzr merge lp://qastaging/~dholbach/snapcraft/1498347
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Review via email: mp+271921@code.qastaging.launchpad.net

Commit message

stage package libgudev-1.0-0, which makes the godd snap actually work

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Thanks for this, but I don't understand :-)

This is strange, it would either be needed as a stage-package or as a build-package; if introducing it as a stage-package (to get a shared lib in the end) you should introduce fileset usage to not have the snap full of development headers and remove the build-package.

review: Needs Information
Revision history for this message
Daniel Holbach (dholbach) wrote :

Not sure I understand. AFAICS you need libgudev-1.0-dev installed as part of build-packages (for the build to pass locally) AND to bundle libudev-1.0-0 for the snap to work on a snappy system.

lp://qastaging/~dholbach/snapcraft/1498347 updated
193. By Daniel Holbach

merged lp:~mvo/snapcraft/1498347

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

and here's the real real one ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches