Merge lp://qastaging/~dholbach/snapcraft/examples-tour into lp://qastaging/~snappy-dev/snapcraft/core

Proposed by Daniel Holbach
Status: Merged
Approved by: Leo Arias
Approved revision: 219
Merged at revision: 218
Proposed branch: lp://qastaging/~dholbach/snapcraft/examples-tour
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 201 lines (+189/-0)
2 files modified
.bzrignore (+1/-0)
docs/snapcraft-advanced-features.md (+188/-0)
To merge this branch: bzr merge lp://qastaging/~dholbach/snapcraft/examples-tour
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+272603@code.qastaging.launchpad.net

Commit message

add a tour which details and explains relevant snapcraft features in the examples directory

To post a comment you must log in.
212. By Leo Arias

Fixed the heading on the build section of the docs. by elopio approved by dholbach

Revision history for this message
Leo Arias (elopio) wrote :

This is great Daniel. Thank you very much.

I've left some typos on the diff, and some other (ignorable) comments.

review: Needs Fixing
Revision history for this message
Daniel Holbach (dholbach) wrote :

Up for another review.

213. By Sergio Schvezov

Mask tar files so they are writable and set an extraction parameter to start with a clean build dir by sergiusens approved by sergiusens,mvo

214. By Sergio Schvezov

Auto detect tar sources by sergiusens approved by sergiusens,zyga

215. By Sergio Schvezov

Adding a simple scons plugin by sergiusens approved by chipaca

216. By Zygmunt Krynicki

Make integration tests easier to write by zyga approved by sergiusens

217. By Sergio Schvezov

Revert type to plugin by sergiusens approved by sergiusens,zyga

Revision history for this message
Leo Arias (elopio) wrote :

Daniel, Sergio has reverted the type/plugin change. So now everywhere in your branch where you mention type, it must be replaced by plugin.

review: Needs Fixing
218. By Daniel Holbach

merge lp:~dholbach/snapcraft/examples-tour

219. By Daniel Holbach

type → plugin

Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks, fixed!

Revision history for this message
Leo Arias (elopio) wrote :

thank you!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches