Snapcraft

Merge lp://qastaging/~dholbach/snapcraft/fix-for-empty-stage_packages-in-plugins into lp://qastaging/~snappy-dev/snapcraft/core

  1. fix-for-empty-stage_packages-in-plugins
  2. Merge into core
Proposed by Daniel Holbach
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 164
Merged at revision: 164
Proposed branch: lp://qastaging/~dholbach/snapcraft/fix-for-empty-stage_packages-in-plugins
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 12 lines (+1/-1)
1 file modified
snapcraft/__init__.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~dholbach/snapcraft/fix-for-empty-stage_packages-in-plugins
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Review via email: mp+271090@code.qastaging.launchpad.net

Commit message

fix crash when stage_packages is defined in the yaml for the plugin, but empty (getattr does not use [] as default return value in that case)

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Thanks for this, I have this available in a complicated branch, I'll take your fix as it is isolated :-)

In case you want to take a look https://code.launchpad.net/~sergiusens/snapcraft/config/+merge/270989 ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches