Merge ~dhuggins/ubuntu/+source/graphviz:dhd/fix_2015017_2015023 into ubuntu/+source/graphviz:ubuntu/devel

Proposed by David Huggins-Daines
Status: Needs review
Proposed branch: ~dhuggins/ubuntu/+source/graphviz:dhd/fix_2015017_2015023
Merge into: ubuntu/+source/graphviz:ubuntu/devel
Diff against target: 72 lines (+41/-0) (has conflicts)
3 files modified
debian/changelog (+20/-0)
debian/patches/series (+5/-0)
debian/patches/svg-scaling.patch (+16/-0)
Conflict in debian/changelog
Conflict in debian/patches/series
Reviewer Review Type Date Requested Status
Dave Jones (community) Needs Fixing
git-ubuntu import Pending
Review via email: mp+440197@code.qastaging.launchpad.net

Description of the change

As the branch name says, it fixes #2015017 and #2015023

To post a comment you must log in.
Revision history for this message
Dave Jones (waveform) wrote (last edit ):

As mentioned in LP: #2015023 I think the python2 changes aren't valid (python2 was removed in lunar and the present graphviz version has been building happily in lunar and mantic), but the LP: #2015017 bug looks valid. If the python compatibility changes could be removed, I could see about getting this sponsored for mantic?

(as an aside: I had a quick check upstream and the latest version in Debian is 2.42.2-7 as well so we can't sync the fixes from there yet)

review: Needs Fixing
Revision history for this message
David Huggins-Daines (dhuggins) wrote :

You can just remove the python stuff.... I really just care about the SVG problem, which makes it super annoying to use graphviz in Jupyter, among other things.

But again ... and it's not your fault ... why in the world has it been four years since Debian/Ubuntu updated the version?

Graphviz introduced this bug in 2.42.0, there was a 2.42.4 patch release that fixes it

But this release can no longer be found on their download page because it's so ancient!!!

Revision history for this message
David Huggins-Daines (dhuggins) :
Revision history for this message
David Huggins-Daines (dhuggins) :
Revision history for this message
David Huggins-Daines (dhuggins) :
Revision history for this message
David Huggins-Daines (dhuggins) wrote (last edit ):

Deleted some overly incendiary comments.

I've updated this to fix only the one problem which has been causing me immense frustration for over a year now.

If you could *please* take a look at this soon that would be really great.

Sorry I let my frustration with the general level of brokenness I encounter in Ubuntu packages get the best of me, nothing personal. In the meantime I'll be updating documentation to say "don't install graphviz from Debian/Ubuntu, it is ancient and has annoying bugs".

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches