Merge lp://qastaging/~didrocks/unity-2d/subdatadir into lp://qastaging/unity-2d

Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Aurélien Gâteau
Approved revision: 639
Merged at revision: 639
Proposed branch: lp://qastaging/~didrocks/unity-2d/subdatadir
Merge into: lp://qastaging/unity-2d
Diff against target: 61 lines (+22/-3)
2 files modified
libunity-2d-private/src/launcherapplicationslist.cpp (+20/-2)
libunity-2d-private/src/launcherapplicationslist.h (+2/-1)
To merge this branch: bzr merge lp://qastaging/~didrocks/unity-2d/subdatadir
Reviewer Review Type Date Requested Status
Aurélien Gâteau (community) Approve
Review via email: mp+70463@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-08-04.

Description of the change

[launcher] Enable storing subdir (like kde4/) in the gsettings schema.
For instance /usr/share/applications/kde4/konversation.desktop should be stored
as kde4-konversation.desktop.

This is valid for all .desktop file in XDG_DATA_DIR/applications.
Note that full path and relative path are still supported

To post a comment you must log in.
637. By Didier Roche-Tolomelli

fix typo

Revision history for this message
Aurélien Gâteau (agateau) wrote :

Works fine, thanks!

I have a few remarks regarding implementation, though:

# Coding style
This file is old and does not comply with unity-2d coding style, but we try to ensure new code does comply. Changes to do are:
- Use camelCase for variables
- Use curly braces for single line ifs
- Attach opening curly brace with the previous line (ie: "if (foo) {", not "if (foo)\n{")
- Whenever possible, use const refs for looping variables in Q_FOREACH

See the CODING file at the root of the repository

# Implementation
- What you are storing in m_xdg_data_dirs is no longer the list of data dirs, it is the list of application dirs. I would suggest renaming the variable to m_xdgApplicationDirs and implement the parsing this way:

Q_FOREACH(const QString& dirName, xdgString.split(':')) {
    m_xdgApplicationDirs << QDir::cleanPath(dirName + "/applications/");
}

- favoriteFromDesktopFilePath() is no longer a static method but it does not modify the object, so it should be marked "const".

review: Needs Fixing
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks Aurélien.

The new version (once the network will allow me to push it) should address all the concerns there. Please note that I slightly changed your example code (as cleanPath remove the final "/").

638. By Didier Roche-Tolomelli

make it more elegant, follow unity-2d guidelines and send a reference for favoriteFromDesktopFilePath (LP: #741129)

639. By Didier Roche-Tolomelli

fixing coding guidelines

Revision history for this message
Aurélien Gâteau (agateau) wrote :

Looks good, approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches