Music Lens

Merge lp://qastaging/~didrocks/unity-lens-music/add-conditional-activation into lp://qastaging/unity-lens-music

  1. add-conditional-activation
  2. Merge into trunk
Proposed by Didier Roche-Tolomelli
Status: Merged
Approved by: Michal Hruby
Approved revision: 114
Merged at revision: 110
Proposed branch: lp://qastaging/~didrocks/unity-lens-music/add-conditional-activation
Merge into: lp://qastaging/unity-lens-music
Diff against target: 71 lines (+30/-1)
3 files modified
configure.ac (+1/-1)
src/musicstore-scope.vala (+14/-0)
tests/manual/activation-remote-scope.txt (+15/-0)
To merge this branch: bzr merge lp://qastaging/~didrocks/unity-lens-music/add-conditional-activation
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+126395@code.qastaging.launchpad.net

Commit message

add conditional search activation to the remote scope (LP: #1054746)

Description of the change

add conditional search activation to the music remote scope (LP: #1054746)

Add manual test as for the rest of the lens.

To post a comment you must log in.
lp://qastaging/~didrocks/unity-lens-music/add-conditional-activation updated
113. By Didier Roche-Tolomelli

comply to latest API

Revision history for this message
Michal Hruby (mhr3) wrote :

Looking good, two things though:

37 + message ("Unity shopping lens online search disabled.");

Drop the msg, it's not necessary, and would only cause console spam since it's logged with every search.

21 + private PreferencesManager preferences = PreferencesManager.get_default ();

The scope should listen to changes on the remote_content_search property and call queue_search_changed() to make the setting take effect immediately.

review: Needs Fixing
lp://qastaging/~didrocks/unity-lens-music/add-conditional-activation updated
114. By Didier Roche-Tolomelli

listen to remote change and remove message

Revision history for this message
Michal Hruby (mhr3) wrote :

Looking good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches