Merge lp://qastaging/~didrocks/unity/dont-ack-multiple-place-requests into lp://qastaging/unity
| Status: | Merged |
|---|---|
| Approved by: | Gord Allott |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1168 |
| Proposed branch: | lp://qastaging/~didrocks/unity/dont-ack-multiple-place-requests |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
223 lines (+89/-8) 5 files modified
src/PanelTitlebarGrabAreaView.cpp (+3/-3) src/PlacesController.cpp (+44/-4) src/PlacesController.h (+6/-0) src/PlacesHomeView.cpp (+32/-1) src/PlacesHomeView.h (+4/-0) |
| To merge this branch: | bzr merge lp://qastaging/~didrocks/unity/dont-ack-multiple-place-requests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity Team | Pending | ||
|
Review via email:
|
|||
Description of the change
Don't ack double/triple click or super press on bfb and places icons.
(LP: #766776)
This is workarounded in different files right now, the correct fix will be to
handle that in the ubus level (too risky at this stage), added FIXME to remember
that for oneiric.
There is one glitch though, which cannot been tackled without the ubus rewrite:
- if you open a place, then, double click on a placeicon in the launcher to
close it, it will be closed by will be reactivated (this is because we send
the UBUS_PLACE_
- so, the next super press will not show the home dash, but the active place
(closing/opening it again will reset to the home dash)
I still think it's an improvment (see Charline's report in maverick for double
clicking on bfb and people being puzzled) and the last described glitch only
impact people double clicking on a place LauncherIcon for closing it…
