Unity

Merge lp://qastaging/~didrocks/unity/fix-711964 into lp://qastaging/unity

  1. fix-711964
  2. Merge into trunk
Proposed by Didier Roche-Tolomelli
Status: Merged
Merged at revision: 816
Proposed branch: lp://qastaging/~didrocks/unity/fix-711964
Merge into: lp://qastaging/unity
Diff against target: 12 lines (+1/-1)
1 file modified
tools/migrate_favorites.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~didrocks/unity/fix-711964
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+48350@code.qastaging.launchpad.net

Description of the change

create intermediate local file if we are the first (LP: #711964)

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I think you'll get an exception here in the positive case? From the docs of makedirs(): "Raises an error exception if the leaf directory already exists or cannot be created".

review: Needs Information
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

hence the if not os.path.isdir(data_path)

Ok, the probability it's a file is thin, but I an check it if needed to remove it first.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

ah, i missed that, sorry :-)

if there's a file there something is askew and it's probably ok to err out

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.