Merge lp://qastaging/~didrocks/unity/fix-lens-shortcuts into lp://qastaging/unity

Awesome stuff! I found a couple of niggles, not sure if they are to do with your branch or not, so let me know:

- Pressing Super no longer shows the numbers on the icons :/
- If I press Super+f quickly, then the dash shows and hides, instead of just showing. I have to press super, wait around 100ms and then press f to make it show.

Any ideas?

The missing numbers and letters when holding down super is already in
Oneiric, so definitely not from this branch.

On 08/09/11 04:10, Didier Roche wrote:

+Lens::Ptr FilesystemLenses::Impl::GetLensForShortcut(std::string const&
lens_shortcut) const
+{
+ Lens::Ptr p;
+
+ for (Lens::Ptr lens: lenses_)
+ {
+ if (lens->shortcut == lens_shortcut)
+ {
+ p = lens;
+ break;
+ }
+ }
+
+ return p;
+}

In a previous branch I found some weirdness with break nor exiting the
new range based for loop. What I found fixed it was to return. So
something like this:

Lens::Ptr FilesystemLenses::Impl::GetLensForShortcut(std::string const&
lens_shortcut) const
{
   for (auto lens : lenses_)
   {
     if (lens->shortcut == lens_shortcut)
       return lens
   }
   return Lens::Ptr();
}

You could use "auto" or "Lens::Ptr const&". Using just Lens::Ptr causes
an extra object to be constructed and destroyed for each time through
the loop.

Tim

I've made the change mentionned by Tim in UnityCore, I've also fixed another one in UnityCore which had a similar pattern.

The "quick typing shortcut" is now fixed as well. But that makes me thing that we should have a keybinding controller which has a reference to both models to trigger the actions in both the Launcher and Dash, being able to know about both part and so avoiding the "show/hide" in a short period of time like we had there.
I initially put everything in the Launcher as it's where we controlled all the Super keys, but it's not the case anymore with this branch, so we should think about it. I'll get to it, but maybe after this release.

Please tell me if it fixes this :)
There is still the issue in first launch (will need to check compiz registration process with Sam)
The numbers not showing and acting is an oneiric regression, indeed, not related to this branch. I'll try to have a look there as well later (some people will apparently break some libunity ABI, and that + patch piloting + zomg new Qt! needs some attention from now ;))

Sweet, approved!