Ubuntu One Client

Merge lp://qastaging/~diegosarmentero/ubuntuone-client/ubuntuone-client-fix-tests into lp://qastaging/ubuntuone-client

  1. ubuntuone-client-fix-tests
  2. Merge into trunk
Proposed by Diego Sarmentero
Status: Merged
Approved by: dobey
Approved revision: 1331
Merged at revision: 1333
Proposed branch: lp://qastaging/~diegosarmentero/ubuntuone-client/ubuntuone-client-fix-tests
Merge into: lp://qastaging/ubuntuone-client
Diff against target: 32 lines (+7/-4)
1 file modified
tests/platform/sync_menu/test_linux.py (+7/-4)
To merge this branch: bzr merge lp://qastaging/~diegosarmentero/ubuntuone-client/ubuntuone-client-fix-tests
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
dobey (community) Approve
Review via email: mp+127836@code.qastaging.launchpad.net

Commit message

- Fixed failing test (LP: #1061100).

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

May I suggest:

15 # The menu should only show 5 current transfers.

Your change makes this 5 a 6.

review: Needs Fixing
lp://qastaging/~diegosarmentero/ubuntuone-client/ubuntuone-client-fix-tests updated
1331. By Diego Sarmentero

fix comment

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

> May I suggest:
>
> 15 # The menu should only show 5 current transfers.
>
> Your change makes this 5 a 6.

comment updated

Revision history for this message
Vincent Ladeuil (vila) wrote :

thanks, it was worth updating the comment, I wouldn't have thought about a separator...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches