Merge ~dirksu/plainbox-provider-checkbox:fixed_orientation into plainbox-provider-checkbox:master

Proposed by Dirk Su
Status: Needs review
Proposed branch: ~dirksu/plainbox-provider-checkbox:fixed_orientation
Merge into: plainbox-provider-checkbox:master
Diff against target: 58 lines (+31/-19)
1 file modified
bin/fixed_screen_orientation.sh (+31/-19)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Needs Information
Kai-Chuan Hsieh Approve
Maciej Kisielewski Pending
Checkbox Developers Pending
StanleyHuang Pending
Clair Lin Pending
PeiYao Chang Pending
Jonathan Cave Pending
Review via email: mp+430014@code.qastaging.launchpad.net

Commit message

Use property PanelOrientationManaged to check autorotation

Description of the change

In Jammy, mutter add new property PanelOrientationManaged to expose panel auto orientation handling [1]. Proposed to use this property for more precise screen orientation detection. [2] for property description in
jammy source tree.

[1] https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1311
[2] https://git.launchpad.net/ubuntu/+source/mutter/tree/data/dbus-interfaces/org.gnome.Mutter.DisplayConfig.xml?h=ubuntu/jammy#n286

To post a comment you must log in.
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

LGTM.

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Please confirm the test still works with older releases (e.g focal) and using checkbox remote (as calls to dbus-send may not work as expected).

review: Needs Information

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches