Provider for Plainbox - PC Sanity

Merge ~dirksu/plainbox-provider-pc-sanity:check_pci_devcie_without_driver into plainbox-provider-pc-sanity:master

  1. Git
  2. lp:~dirksu/plainbox-provider-pc-sanity
  3. check_pci_devcie_without_driver
  4. Merge into master
Proposed by Dirk Su
Status: Rejected
Rejected by: Dirk Su
Proposed branch: ~dirksu/plainbox-provider-pc-sanity:check_pci_devcie_without_driver
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 41 lines (+27/-0)
2 files modified
bin/list_pci_device_without_driver.sh (+19/-0)
units/pc-sanity/pc-sanity-check-devices.pxu (+8/-0)
Reviewer Review Type Date Requested Status
Dirk Su Disapprove
Kai-Chuan Hsieh Needs Information
Review via email: mp+455243@code.qastaging.launchpad.net

Commit message

Add test case to check if PCI device load the driver correctly

To post a comment you must log in.
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Did you check the same policy can be applied on other SoC? ex. AMD

Can we upstream such test case to checkbox?

review: Needs Information
Revision history for this message
Dirk Su (dirksu) wrote (last edit ):

Result from AMD platform Tramore

/sys/bus/pci/devices/0000:00:00.2
0x1022
0x149e
/sys/bus/pci/devices/0000:11:00.0
0x1022
0x14ac
/sys/bus/pci/devices/0000:12:00.0
0x1022
0x14ac
/sys/bus/pci/devices/0000:40:00.2
0x1022
0x149e
/sys/bus/pci/devices/0000:41:00.0
0x1022
0x14ac
/sys/bus/pci/devices/0000:80:00.2
0x1022
0x149e
/sys/bus/pci/devices/0000:87:00.0
0x1022
0x14ac
/sys/bus/pci/devices/0000:c0:00.2
0x1022
0x149e
/sys/bus/pci/devices/0000:c1:00.0
0x1022
0x14ac

Revision history for this message
Dirk Su (dirksu) wrote :

Result from Intel MTL machine

/sys/bus/pci/devices/0000:00:08.0
0x8086
0x7e4c
/sys/bus/pci/devices/10000:e0:06.0
0x8086
0x09ab

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

> Result from AMD platform Tramore
>
> /sys/bus/pci/devices/0000:00:00.2
> 0x1022
> 0x149e
> /sys/bus/pci/devices/0000:11:00.0
> 0x1022
> 0x14ac
> /sys/bus/pci/devices/0000:12:00.0
> 0x1022
> 0x14ac
> /sys/bus/pci/devices/0000:40:00.2
> 0x1022
> 0x149e
> /sys/bus/pci/devices/0000:41:00.0
> 0x1022
> 0x14ac
> /sys/bus/pci/devices/0000:80:00.2
> 0x1022
> 0x149e
> /sys/bus/pci/devices/0000:87:00.0
> 0x1022
> 0x14ac
> /sys/bus/pci/devices/0000:c0:00.2
> 0x1022
> 0x149e
> /sys/bus/pci/devices/0000:c1:00.0
> 0x1022
> 0x14ac

Do you mean these devices have no driver?

Revision history for this message
Dirk Su (dirksu) wrote :

Yes, those device don't have driver
from the lspci command, those are

IOMMU: Advanced Micro Devices
Non-Essential Instrumentation

> > Result from AMD platform Tramore
> >
> > /sys/bus/pci/devices/0000:00:00.2
> > 0x1022
> > 0x149e
> > /sys/bus/pci/devices/0000:11:00.0
> > 0x1022
> > 0x14ac
> > /sys/bus/pci/devices/0000:12:00.0
> > 0x1022
> > 0x14ac
> > /sys/bus/pci/devices/0000:40:00.2
> > 0x1022
> > 0x149e
> > /sys/bus/pci/devices/0000:41:00.0
> > 0x1022
> > 0x14ac
> > /sys/bus/pci/devices/0000:80:00.2
> > 0x1022
> > 0x149e
> > /sys/bus/pci/devices/0000:87:00.0
> > 0x1022
> > 0x14ac
> > /sys/bus/pci/devices/0000:c0:00.2
> > 0x1022
> > 0x149e
> > /sys/bus/pci/devices/0000:c1:00.0
> > 0x1022
> > 0x14ac
>
> Do you mean these devices have no driver?

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

> Yes, those device don't have driver
> from the lspci command, those are
>
> IOMMU: Advanced Micro Devices
> Non-Essential Instrumentation
>
> > > Result from AMD platform Tramore
> > >
> > > /sys/bus/pci/devices/0000:00:00.2
> > > 0x1022
> > > 0x149e
> > > /sys/bus/pci/devices/0000:11:00.0
> > > 0x1022
> > > 0x14ac
> > > /sys/bus/pci/devices/0000:12:00.0
> > > 0x1022
> > > 0x14ac
> > > /sys/bus/pci/devices/0000:40:00.2
> > > 0x1022
> > > 0x149e
> > > /sys/bus/pci/devices/0000:41:00.0
> > > 0x1022
> > > 0x14ac
> > > /sys/bus/pci/devices/0000:80:00.2
> > > 0x1022
> > > 0x149e
> > > /sys/bus/pci/devices/0000:87:00.0
> > > 0x1022
> > > 0x14ac
> > > /sys/bus/pci/devices/0000:c0:00.2
> > > 0x1022
> > > 0x149e
> > > /sys/bus/pci/devices/0000:c1:00.0
> > > 0x1022
> > > 0x14ac
> >
> > Do you mean these devices have no driver?

The job will be failed on all platforms, is it acceptable from our daily work?
I don't think all pci devices should have driver probed, it is because not all devices are complied Linux POR from vendor point of view.

Revision history for this message
Dirk Su (dirksu) wrote :

Based on the test results with Intel MTL and AMD platforms. Some PCI devices don't have driver, will make this test job always fail. And trigger false alarm.

review: Disapprove

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches