Merge lp://qastaging/~divmod-dev/divmod.org/1304710-storeless-adapter into lp://qastaging/divmod.org

Proposed by Tristan Seligmann
Status: Merged
Merged at revision: 2748
Proposed branch: lp://qastaging/~divmod-dev/divmod.org/1304710-storeless-adapter
Merge into: lp://qastaging/divmod.org
Diff against target: 77 lines (+34/-5)
2 files modified
Axiom/axiom/item.py (+3/-5)
Axiom/axiom/test/test_powerup.py (+31/-0)
To merge this branch: bzr merge lp://qastaging/~divmod-dev/divmod.org/1304710-storeless-adapter
Reviewer Review Type Date Requested Status
Tristan Seligmann Needs Fixing
Jonathan Jacobs Approve
Review via email: mp+214852@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Jacobs (jjacobs) wrote :

This looks good to me, although it would be useful to get a second opinion, in particular from the original author.

review: Approve
Revision history for this message
Tristan Seligmann (mithrandi) wrote :

Note to self: fix "procede" typo.

review: Needs Fixing
Revision history for this message
Laurens Van Houtven (lvh) wrote :

Looks good modulo your typo :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: