Merge lp://qastaging/~divmod-dev/divmod.org/829872-createnew-type-check into lp://qastaging/divmod.org

Eliminate $PYTHONPATH rewriting in code that launches python / twistd child processes.

Avoid relying on implicit-close-by-refcounting in the test suite.

Merge branch again for one last trivial deprecation fix that got missed.

Simplify the metaclass trickery that makes subclasses of AxiomaticCommand
automatically provide IPlugin and IAxiomaticCommand.

Remove the indirect-attribute trickery in TypedInterface (which no longer works
with newer versions of z.i) in favour of setting attributes directly on the
interface (which seems to have started working quite some time ago).

Give Imaginary a new basis for how the simulation graph is represented and used.

This changes the basis of the simulation to Ideas, Things, link contributors,
link annotators, and restrictions. It makes the preferred interface to use the
simulation graph `Idea.obtain` or `Thing.obtainOrReportWhyNot`. It also adds
some new application code using these APIs to implement novel behaviors.

Update the Mantissa web integration tests to work with Twisted 11.0.

Merge "duplicate-class-defs".

Merge Pyflakes 0.5.0 release branch.

Update `test_headerToUnicode` to assert better behavior in one of its cases; prior to Python 2.6, some data was lost, and the test asserted that: on Python 2.7, the data is preserved, and the new version of the test now requires that (so the test will fail on Python 2.6, as it should).

Add WindowsError as a known built-in name on all platforms, suppressing warnings about it being used but undefined when using pyflakes on a non-Windows platform.

This may suppress legitimate warnings, since using WindowsError in a code path that
will actually be evaluated on a non-Windows platform is invalid. However, it is too
hard for pyflakes to figure out which code paths will run, so trade the lost legitimate
warnings in exchange for also getting rid of some bogus warnings.

Merge 'amp-vertex-2580'
Author: washort
Reviewer: MostAwesomeDude

Replace JUICE with AMP in Vertex.

Remove 'vertex._unfortunate_defer_hack'

Make Vertex not depend on Epsilon.

Fix several broken uses of the deleted scheduler item type from the Quotient POP3 grabber code.

The scheduler item was removed a while ago. Several untested code paths through the POP3 grabber still used it, though. These are now changed to adapt the store to IScheduler instead. New tests are also added for them.

Fix an unhandled exception in the POP3 grabber timeout case.

Previously the POP3 grabber would fail with an AttributeError if a timeout occurred on the
POP3 connection. This was caused by trying to set the status on the grabber object after
the reference to the grabber object had been discarded. When trying to set the status, the
code now first checks to see if a grabber object is available to do that.

Add extra help for making sure the batch process is started when it is needed.

Any time a remote work item is added, check to see if the batch
process needs to be started. This ensures remote work items
are processed in a slightly more timely fashion than was
previously the case.

Start the scheduler service as soon as the store service is started.

Author: exarkun
Reviewer: mithrandi
Fixes: lp:910923

Update Quotient usage of spambayes to pass the new required `mode` argument when constructing Hammie instances.

This allows Quotient to work with the latest release of spambayes, though it breaks Quotient against older
versions of spambayes.

Switch to using a SQLite3 database for spambayes classifier training data, instead of a pickle file.

Author: exarkun
Reviewer: mithrandi

The reasons for preferring SQLite3 are manifold. Performance, reliability, inspectability,
and maintainability should all be improved by this change. An upgrader is included, of
course, to convert old data. However, the old pickle file is left in place for manual
deletion afterwards, at the discretion of a system administrator.

Improve SQLite3 Spambayes storage implementation performance

Author: exarkun
Reviewer: mithrandi

Change the SQLite3 Spambayes storage implementation to load data for all of a
message's token data in as few SQL operations as possible, instead of
loading one token's data per SQL operation.

Separate logic for reporting results.

 * Author: jml
 * Reviewers: exarkun, jml

Update two Nevow unit tests to work with more recent versions of Twisted

This will introduce a test failure against Twisted < 11.0, but no implementation
changes are actually being made, so no actual functionality should be lost on
old Twisted versions.

Move Pyflakes out of the Divmod.org's repository

vertex moved to https://github.com/twisted/vertex/

Accept varargs in Divmod.UnitTest.TestCase.assertThrows.

Author: jjacobs
Reviewer: exarkun

Pass varargs to assertThrows on to the callable, matching the way Python's assertRaises works.

Make __conform__ work for storeless items with in-memory powerups.

Reformat code.

Write a test, make it pass.

Fix incorrect uses of SubStore.createNew.

Reformat code and change failUnless to assertTrue.

Fix formatting string.

Assert about exception message.

Fix merge.

More fixing.