Divmod

Merge lp://qastaging/~divmod-dev/divmod.org/windowserror-builtin into lp://qastaging/divmod.org

  1. windowserror-builtin
  2. Merge into trunk
Proposed by Jean-Paul Calderone
Status: Merged
Approved by: Tristan Seligmann
Approved revision: 2686
Merged at revision: 2688
Proposed branch: lp://qastaging/~divmod-dev/divmod.org/windowserror-builtin
Merge into: lp://qastaging/divmod.org
Diff against target: 34 lines (+11/-2)
2 files modified
Pyflakes/pyflakes/checker.py (+3/-2)
Pyflakes/pyflakes/test/test_undefined_names.py (+8/-0)
To merge this branch: bzr merge lp://qastaging/~divmod-dev/divmod.org/windowserror-builtin
Reviewer Review Type Date Requested Status
Tristan Seligmann Approve
Jonathan Jacobs Approve
Review via email: mp+84407@code.qastaging.launchpad.net

Description of the change

Change WindowsError to be treated as one of the magic builtins, so it is never warned as an undefined name.

To post a comment you must log in.
Revision history for this message
Jonathan Jacobs (jjacobs) wrote :

Horribleness magic globals aside, this looks good to merge.

review: Approve
Revision history for this message
Tristan Seligmann (mithrandi) wrote :

This renders the comment above the _MAGIC_GLOBALS definition slightly inaccurate; how about appending something like "or are only present on some platforms"?

review: Needs Fixing
lp://qastaging/~divmod-dev/divmod.org/windowserror-builtin updated
2686. By Jean-Paul Calderone

Adjust the comment about _MAGIC_GLOBALS, explaining that it also papers over cross-platform __builtin__ differences.

Revision history for this message
Tristan Seligmann (mithrandi) wrote :

Looks good! (sorry for the latency in responding to this, Launchpad doesn't send notifications when a merge proposal's branch is updated, only when comments are made on the MP)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: