lp://qastaging/~diwic/alsa-driver/snd-firewire-improve

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

2 recipes using this branch. (?)

Related snap packages

Related bugs

Related blueprints

1110. By Takashi Sakamoto on 2025-10-13

add support for DKMS

1109. By Takashi Sakamoto on 2025-10-13

add README

1108. By Takashi Sakamoto on 2025-09-28

firewire: core: fix undefined reference error in ARM EABI

For ARM EABI, GCC generates a reference to __aeabi_uldivmod when compiling
a division of 64-bit integer with 32-bit integer. This function is not
available in Linux kernel. In such cases, helper macros are defined in
include/linux/math64.h.

This commit replaces the division with div_u64().

Fixes: 8ec6a8ec23b9 ("firewire: core: suppress overflow warning when computing jiffies from isochronous cycle")
Reported-by: kernel test robot <email address hidden>
Closes: https://<email address hidden>/
Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1107. By Takashi Sakamoto on 2025-09-24

Revert "firewire: core: disable bus management work temporarily during updating topology"

This reverts commit abe7159125702c734e851bc0c52b51cd446298a5.

The bus manager work item acquires the spin lock of fw_card again, thus
no need to serialize it against fw_core_handle_bus_reset().

Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1106. By Takashi Sakamoto on 2025-09-24

Revert "firewire: core: shrink critical section of fw_card spinlock in bm_work"

This reverts commit 582310376d6e9a8d261b682178713cdc4b251af6.

The bus manager work has the race condition against fw_destroy_nodes()
called by fw_core_remove_card(). The acquition of spin lock of fw_card
is left as is again.

Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1105. By Takashi Sakamoto on 2025-09-24

firewire: core: suppress overflow warning when computing jiffies from isochronous cycle

The multiplication by USEC_PER_SEC (=1000000L) may trigger an overflow
warning with 32 bit storage. In the case of the subsystem the input value
ranges between 800 and 16000, thus the result always fits within 32 bit
storage.

This commit suppresses the warning by using widening conversion to 64 bit
storage before multiplication, then using narrowing conversion to 32 bit
storage.

Reported-by: kernel test robot <email address hidden>
Closes: https://<email address hidden>/
Fixes: 379b870c28c6 ("firewire: core: use helper macros instead of direct access to HZ")
Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1104. By Takashi Sakamoto on 2025-09-20

firewire: core: fix overlooked update of subsystem ABI version

In kernel v6.5, several functions were added to the cdev layer. This
required updating the default version of subsystem ABI up to 6, but
this requirement was overlooked.

This commit updates the version accordingly.

Fixes: 6add87e9764d ("firewire: cdev: add new version of ABI to notify time stamp at request/response subaction of transaction#")
Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1103. By Takashi Sakamoto on 2025-09-18

firewire: core: minor code refactoring to delete useless local variable

The do_reset local variable has less merit. Let's remove it.

Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1102. By Takashi Sakamoto on 2025-09-18

firewire: core; eliminate pick_me goto label

This commit uses condition statements instead of pick_me goto label.

Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1101. By Takashi Sakamoto on 2025-09-18

firewire: core: code refactoring to split contention procedure for bus manager

The precedure to contend for bus manager has much code. It is better to
split it into a helper function.

This commit refactors in the point.

Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>