ALSA driver

lp://qastaging/~diwic/alsa-driver/snd-firewire-improve

Created by David Henningsson and last modified

Takashi Sakamoto's firewire drivers

Get this branch:
bzr branch lp://qastaging/~diwic/alsa-driver/snd-firewire-improve

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
David Henningsson
Project:
ALSA driver
Status:
Development

Import details

Import Status: Suspended

This branch is an import of the HEAD branch of the Git repository at https://github.com/takaswie/snd-firewire-improve.git.

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 20 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-4 and finished taking 40 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 30 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 20 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 20 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 20 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 15 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 40 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 20 seconds — see the log

Recent revisions

1015. By Takashi Sakamoto

add DKMS support

1014. By Takashi Sakamoto

Revert "firewire: ohci: Replace deprecated PCI functions"

This reverts commit a83335944a52aae802e0e10c65097a44e0eccfd4.

1013. By Takashi Sakamoto

Revert "move asm/unaligned.h to linux/unaligned.h"

This reverts commit 775572853757846474468262dc2f2e12f6b29665.

1012. By Takashi Sakamoto

add README

1011. By Luo Yifan <email address hidden>

tools/firewire: Fix several incorrect format specifiers

Make a minor change to eliminate static checker warnings. Fix several
incorrect format specifiers that misused signed and unsigned versions.

Signed-off-by: Luo Yifan <email address hidden>
Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1010. By Murad Masimov <email address hidden>

ALSA: firewire-lib: fix return value on fail in amdtp_tscm_init()

If amdtp_stream_init() fails in amdtp_tscm_init(), the latter returns zero,
though it's supposed to return error code, which is checked inside
init_stream() in file tascam-stream.c.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 47faeea25ef3 ("ALSA: firewire-tascam: add data block processing layer")
Signed-off-by: Murad Masimov <email address hidden>
Reviewed-by: Takashi Sakamoto <email address hidden>
Signed-off-by: Takashi Iwai <email address hidden>
Link: https://<email address hidden>

1009. By Philipp Stanner <email address hidden>

firewire: ohci: Replace deprecated PCI functions

pcim_iomap_regions() and pcim_iomap_table() have been deprecated in
commit e354bb84a4c1 ("PCI: Deprecate pcim_iomap_table(),
pcim_iomap_regions_request_all()").

Replace these functions with pcim_iomap_region().

Signed-off-by: Philipp Stanner <email address hidden>
Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1008. By Dr. David Alan Gilbert <email address hidden>

ALSA: firewire: Remove unused cmp_connection_update

cmp_connection_update() has been unused since 2019's commit
7eb7b18e9fc7 ("ALSA: fireworks: code refactoring for bus reset handler")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <email address hidden>
Reviewed-by: Takashi Sakamoto <email address hidden>
Signed-off-by: Takashi Iwai <email address hidden>
Link: https://<email address hidden>

1007. By Shen Lichuan <email address hidden>

firewire: Correct some typos

Fixed some confusing typos that were currently identified with codespell,
the details are as follows:

drivers/firewire/core-topology.c:59: containted ==> contained
drivers/firewire/core.h:83: reenable ==> re-enable
drivers/firewire/ohci.c:1387: apppends ==> appends
drivers/firewire/ohci.c:2216: superceded ==> superseded
drivers/firewire/ohci.c:2617: litte ==> little

Signed-off-by: Shen Lichuan <email address hidden>
Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

1006. By Takashi Sakamoto

firewire: core: fix invalid port index for parent device

In a commit 24b7f8e5cd65 ("firewire: core: use helper functions for self
ID sequence"), the enumeration over self ID sequence was refactored with
some helper functions with KUnit tests. These helper functions are
guaranteed to work expectedly by the KUnit tests, however their application
includes a mistake to assign invalid value to the index of port connected
to parent device.

This bug affects the case that any extra node devices which has three or
more ports are connected to 1394 OHCI controller. In the case, the path
to update the tree cache could hits WARN_ON(), and gets general protection
fault due to the access to invalid address computed by the invalid value.

This commit fixes the bug to assign correct port index.

Cc: <email address hidden>
Reported-by: Edmund Raile <email address hidden>
Closes: https://lore<email address hidden>/
Fixes: 24b7f8e5cd65 ("firewire: core: use helper functions for self ID sequence")
Link: https://<email address hidden>
Signed-off-by: Takashi Sakamoto <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.